From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 30EDF1F54E for ; Wed, 17 Aug 2022 20:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbiHQUYG (ORCPT ); Wed, 17 Aug 2022 16:24:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241689AbiHQUYE (ORCPT ); Wed, 17 Aug 2022 16:24:04 -0400 Received: from siwi.pair.com (siwi.pair.com [209.68.5.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3255B5F116 for ; Wed, 17 Aug 2022 13:24:01 -0700 (PDT) Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id 922243F414B; Wed, 17 Aug 2022 16:24:00 -0400 (EDT) Received: from jeffhost-mbp.local (unknown [IPv6:2600:100e:b003:bb50:a8f5:f3c3:a597:485d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 231723F4117; Wed, 17 Aug 2022 16:24:00 -0400 (EDT) Subject: Re: t7527 intermittent failure on macOS APFS and possible fix To: =?UTF-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= , git@vger.kernel.org References: Cc: git@jeffhostetler.com From: Jeff Hostetler Message-ID: Date: Wed, 17 Aug 2022 16:23:57 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: mailmunge 3.09 on 209.68.5.199 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 8/12/22 9:52 AM, Đoàn Trần Công Danh wrote: > Hello, > > Running t7527 on macOS with encrypted APFS filesystem. > I observes intermittent failure, however, when I manually check the > test cases, they're all passed. > > I suspected fileystem caching issue. > I added those sync-s into test steps and the test pass. > I'm not sure if this is the intending "fix" for the tests > since we're testing the fsmonitor with t7527. > > Please advise! > > P/S: When debugging, I also found out that: > "test-tool fsmonitor-client query" doesn't write the final newline > character, thus making the output harder to read. The diff also have > the final newline added. Thanks for the report. Sorry for the delay, I'm still digging thru my email backlog after a long vacation. I'll take a look at this and get back to you shortly. Thanks, Jeff