From: Jeff Hostetler <git@jeffhostetler.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Jeff Hostetler <jeffhost@microsoft.com>,
Jon Simons <jon@jonsimons.org>,
git@vger.kernel.org, me@ttaylorr.com, sunshine@sunshineco.com,
stolee@gmail.com
Subject: Re: [PATCH 0/3] clone --filter=sparse:oid bugs
Date: Mon, 16 Sep 2019 10:31:59 -0400 [thread overview]
Message-ID: <a5e9bfa0-5372-c444-cc42-5ca2f614b1b9@jeffhostetler.com> (raw)
In-Reply-To: <20190915010942.GA19787@sigill.intra.peff.net>
On 9/14/2019 9:09 PM, Jeff King wrote:
> On Mon, Sep 09, 2019 at 01:08:24PM -0400, Jeff King wrote:
>
>> I'll work up what I sent earlier into a real patch, and include some of
>> this discussion.
>
> Here it is. I pulled Jon's tests out into their own patch (mostly
> because it makes it easier to give credit). Then patch 2 is my fix, and
> patch 3 is the message fixups he had done.
>
> This replaces what's queued in js/partial-clone-sparse-blob.
>
> [1/3]: t5616: test cloning/fetching with sparse:oid=<oid> filter
> [2/3]: list-objects-filter: delay parsing of sparse oid
> [3/3]: list-objects-filter: give a more specific error sparse parsing error
>
> builtin/rev-list.c | 4 ----
> list-objects-filter-options.c | 14 ++------------
> list-objects-filter-options.h | 2 +-
> list-objects-filter.c | 14 +++++++++++---
> t/t5616-partial-clone.sh | 36 +++++++++++++++++++++++++++++++++++
> 5 files changed, 50 insertions(+), 20 deletions(-)
>
This series looks good to me.
Thanks!
Jeff
next prev parent reply other threads:[~2019-09-16 14:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 23:19 [PATCH v3 0/2] partial-clone: fix two issues with sparse filter handling Jon Simons
2019-08-29 23:19 ` [PATCH v3 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir' Jon Simons
2019-08-30 18:08 ` Junio C Hamano
2019-09-04 4:54 ` Jeff King
2019-09-05 18:57 ` Junio C Hamano
2019-09-09 13:54 ` Jeff Hostetler
2019-09-09 17:08 ` Jeff King
2019-09-09 20:03 ` Jeff Hostetler
2019-09-15 1:09 ` [PATCH 0/3] clone --filter=sparse:oid bugs Jeff King
2019-09-15 1:11 ` [PATCH 1/3] t5616: test cloning/fetching with sparse:oid=<oid> filter Jeff King
2019-09-15 1:13 ` [PATCH 2/3] list-objects-filter: delay parsing of sparse oid Jeff King
2019-09-15 16:12 ` Jeff King
2019-09-17 19:22 ` Junio C Hamano
2019-09-15 1:13 ` [PATCH 3/3] list-objects-filter: give a more specific error sparse parsing error Jeff King
2019-09-15 16:51 ` [PATCH 4/3] list-objects-filter: use empty string instead of NULL for sparse "base" Jeff King
2019-09-16 14:31 ` Jeff Hostetler [this message]
2019-09-09 17:12 ` [PATCH v3 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir' Junio C Hamano
2019-09-09 19:49 ` Jeff Hostetler
2019-08-29 23:19 ` [PATCH v3 2/2] list-objects-filter: handle unresolved sparse filter OID Jon Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5e9bfa0-5372-c444-cc42-5ca2f614b1b9@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jon@jonsimons.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).