From: Jeff Hostetler <git@jeffhostetler.com>
To: Philip Oakley <philipoakley@iee.org>, GitList <git@vger.kernel.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] compat/vcbuild/README: clean/update 'vcpkg' env for Visual Studio updates
Date: Tue, 28 May 2019 09:56:11 -0400 [thread overview]
Message-ID: <a48d5f62-081a-de14-5dbb-4726908a4179@jeffhostetler.com> (raw)
In-Reply-To: <20190528120846.1056-1-philipoakley@iee.org>
On 5/28/2019 8:08 AM, Philip Oakley wrote:
> When the user installs an updated version of Visual Studio, the previously
> generated MSVC-DEFS-GEN will need to be deleted to allow updating.
>
> Alternatively the whole vcpkg download may be cleaned allowing it to be
> reloaded, though this may take much longer on slower connections.
>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
>
> In response to discussions at:
> https://github.com/git-for-windows/git/issues/2186
>
> cc: Jeff Hostetler <git@jeffhostetler.com>
> cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>
> compat/vcbuild/README | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/compat/vcbuild/README b/compat/vcbuild/README
> index 81da36a93b..40695fc1cc 100644
> --- a/compat/vcbuild/README
> +++ b/compat/vcbuild/README
> @@ -18,6 +18,13 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
> Makefile:
> <repo_root>/compat/vcbuild/MSVC-DEFS-GEN
>
> + - If you update your Visual Studio version, then delete the MSVC-DEFS-GEN
> + file so that fresh environment variables can be discovered.
> +
> + Or clean the "vcpkg" environment with:
> +
> + $ make MSVC=1 clean
> +
> 2. OPTIONALLY copy the third-party *.dll and *.pdb files into the repo
> root to make it easier to run and debug git.exe without having to
> manipulate your PATH. This is especially true for debug sessions in
>
Did you mean to send this upstream or to Git for Windows?
I didn't think that the VS2015/VS2017 vcpkg-aware version of
compat/vcbuild/* had made it upstream yet, so this patch might not
apply upstream.
BTW, the Makefile (when MSVC=1 is defined) will take care of deleting
the MSVC-DEFS-GEN, so all we really need to say here is to do:
$ make MSVC=1 clean
or $ make MSVC=1 DEBUG=1 clean
after upgrading to a new version of VS.
Jeff
PS. I have a TODO item to fix the Makefile to automatically detect
and take care of this.
next prev parent reply other threads:[~2019-05-28 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 12:08 [PATCH] compat/vcbuild/README: clean/update 'vcpkg' env for Visual Studio updates Philip Oakley
2019-05-28 13:56 ` Jeff Hostetler [this message]
2019-05-28 14:09 ` Philip Oakley
2019-05-28 14:32 ` Jeff Hostetler
2019-05-28 18:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48d5f62-081a-de14-5dbb-4726908a4179@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).