git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH 1/2] transport.c: modify comment in transport_get().
@ 2021-03-24  5:36 lilinchao
  2021-03-24 20:23 ` Junio C Hamano
       [not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
  0 siblings, 2 replies; 3+ messages in thread
From: lilinchao @ 2021-03-24  5:36 UTC (permalink / raw)
  To: git; +Cc: gitster, lilinchao

From: lilinchao <lilinchao@oschina.cn>

Signed-off-by: lilinchao <lilinchao@oschina.cn>
---
 transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport.c b/transport.c
index 1c4ab676d1..71b3d44cf3 100644
--- a/transport.c
+++ b/transport.c
@@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
 		data->conn = NULL;
 		data->got_remote_heads = 0;
 	} else {
-		/* Unknown protocol in URL. Pass to external handler. */
+		/* Http/https and other unknown protocol in URL. Pass to external handler. */
 		int len = external_specification_len(url);
 		char *handler = xmemdupz(url, len);
 		transport_helper_init(ret, handler);
-- 
2.30.0.1006.g4a81e96670


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] transport.c: modify comment in transport_get().
  2021-03-24  5:36 [PATCH 1/2] transport.c: modify comment in transport_get() lilinchao
@ 2021-03-24 20:23 ` Junio C Hamano
       [not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2021-03-24 20:23 UTC (permalink / raw)
  To: lilinchao; +Cc: git

lilinchao@oschina.cn writes:

> From: lilinchao <lilinchao@oschina.cn>
>
> Signed-off-by: lilinchao <lilinchao@oschina.cn>
> ---
>  transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport.c b/transport.c
> index 1c4ab676d1..71b3d44cf3 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
>  		data->conn = NULL;
>  		data->got_remote_heads = 0;
>  	} else {
> -		/* Unknown protocol in URL. Pass to external handler. */
> +		/* Http/https and other unknown protocol in URL. Pass to external handler. */

The previous block says

		/*
		 * These are builtin smart transports; "allowed" transports
		 * will be checked individually in git_connect.
		 */

where it lists file:// git:// and ssh:// URLs.  And contrasting with
that, it should be clear "unknown" refers to "not a builtin that is
known to the C code linked to the same binary" and includes http://
and https://.

IOW, I am not sure adding "http/https and other" to make it an
overlong line is worth doing.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Re: [PATCH 1/2] transport.c: modify comment in transport_get().
       [not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
@ 2021-03-25  3:39   ` lilinchao
  0 siblings, 0 replies; 3+ messages in thread
From: lilinchao @ 2021-03-25  3:39 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

>lilinchao@oschina.cn writes:
>
>> From: lilinchao <lilinchao@oschina.cn>
>>
>> Signed-off-by: lilinchao <lilinchao@oschina.cn>
>> ---
>>  transport.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/transport.c b/transport.c
>> index 1c4ab676d1..71b3d44cf3 100644
>> --- a/transport.c
>> +++ b/transport.c
>> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
>>  data->conn = NULL;
>>  data->got_remote_heads = 0;
>>  } else {
>> -	/* Unknown protocol in URL. Pass to external handler. */
>> +	/* Http/https and other unknown protocol in URL. Pass to external handler. */
>
>The previous block says
>
>	/*
>	* These are builtin smart transports; "allowed" transports
>	* will be checked individually in git_connect.
>	*/
>
>where it lists file:// git:// and ssh:// URLs.  And contrasting with
>that, it should be clear "unknown" refers to "not a builtin that is
>known to the C code linked to the same binary" and includes http://
>and https://.
> 

I think the comment here should explicitly mention that HTTP
is included :)

>IOW, I am not sure adding "http/https and other" to make it an
>overlong line is worth doing.
> 

Indeed, overlong line is not good, I will drop this change.

>Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-25  3:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24  5:36 [PATCH 1/2] transport.c: modify comment in transport_get() lilinchao
2021-03-24 20:23 ` Junio C Hamano
     [not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
2021-03-25  3:39   ` lilinchao

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).