From: "lilinchao@oschina.cn" <lilinchao@oschina.cn>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Re: [PATCH 1/2] transport.c: modify comment in transport_get().
Date: Thu, 25 Mar 2021 11:39:01 +0800 [thread overview]
Message-ID: <a46828308d1b11eb8d710026b95c99cc@oschina.cn> (raw)
In-Reply-To: c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com
>lilinchao@oschina.cn writes:
>
>> From: lilinchao <lilinchao@oschina.cn>
>>
>> Signed-off-by: lilinchao <lilinchao@oschina.cn>
>> ---
>> transport.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/transport.c b/transport.c
>> index 1c4ab676d1..71b3d44cf3 100644
>> --- a/transport.c
>> +++ b/transport.c
>> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
>> data->conn = NULL;
>> data->got_remote_heads = 0;
>> } else {
>> - /* Unknown protocol in URL. Pass to external handler. */
>> + /* Http/https and other unknown protocol in URL. Pass to external handler. */
>
>The previous block says
>
> /*
> * These are builtin smart transports; "allowed" transports
> * will be checked individually in git_connect.
> */
>
>where it lists file:// git:// and ssh:// URLs. And contrasting with
>that, it should be clear "unknown" refers to "not a builtin that is
>known to the C code linked to the same binary" and includes http://
>and https://.
>
I think the comment here should explicitly mention that HTTP
is included :)
>IOW, I am not sure adding "http/https and other" to make it an
>overlong line is worth doing.
>
Indeed, overlong line is not good, I will drop this change.
>Thanks.
prev parent reply other threads:[~2021-03-25 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 5:36 [PATCH 1/2] transport.c: modify comment in transport_get() lilinchao
2021-03-24 20:23 ` Junio C Hamano
[not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
2021-03-25 3:39 ` lilinchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46828308d1b11eb8d710026b95c99cc@oschina.cn \
--to=lilinchao@oschina.cn \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).