From: Daniel Klauer <daniel.c.klauer@web.de>
To: Jeff King <peff@peff.net>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc.com>, git@vger.kernel.org
Subject: Re: bug report: "git pack-redundant --all" crash in minimize()
Date: Wed, 16 Dec 2020 14:22:52 +0100 [thread overview]
Message-ID: <a46660c3-630c-5573-9ef4-75d273d37767@web.de> (raw)
In-Reply-To: <X9j+nuzjiYyw/vQx@coredump.intra.peff.net>
On 15.12.20 19:21, Jeff King wrote:
> On Tue, Dec 15, 2020 at 06:34:53PM +0100, Daniel C. Klauer wrote:
>> The reason this showed up is that Yocto's build tool, bitbake, sometimes
>> invokes this git command on some of the repositories it downloaded. This
>> issue was apparently also reported here:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1803506
>
> We had a discussion not too long ago[1] about whether we should
> deprecate and remove pack-redundant, as it's not generally useful. I'm
> curious if you have any more context on why it's used in that tool.
Background: bitbake downloads git repositories during a build process
and supports caching them locally (in form of bare repos in some
user-defined directory). This prevents having to re-download them during
the next build, and also it is a convenient mirroring/backup system in
case the original URLs stop working.
As far as I can tell (since I'm not a bitbake developer) the git
pack-redundant invocation is one of multiple calls meant to improve
storage (probably minimize disk usage) of the locally cached git repos.
For reference, please take a look at the other git commands it's
invoking [1], and at the commit messages of the commits that added these
invocations [2] [3] [4].
If doing it that way seems wrong, I'll report the issue to bitbake
upstream too. Maybe there is a better way to do whatever bitbake wants
to do here?
Thanks!
[1]
http://git.openembedded.org/bitbake/tree/lib/bb/fetch2/git.py?h=1.48.1#n364
[2]
http://git.openembedded.org/bitbake/commit?id=d5d958744fff66cf5286022d78cbec1839fca2e2
[3]
http://git.openembedded.org/bitbake/commit?id=f8126aaf774186a6eaf0bd4067b89c074594886c
[4]
http://git.openembedded.org/bitbake/commit?id=7d55491f88ff90a4c16ad87b1483d55b1824acfc
next prev parent reply other threads:[~2020-12-16 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:34 bug report: "git pack-redundant --all" crash in minimize() Daniel C. Klauer
2020-12-15 18:21 ` Jeff King
2020-12-15 22:32 ` Junio C Hamano
2020-12-16 9:21 ` Jiang Xin
2020-12-16 10:09 ` [PATCH] pack-redundant: fix crash when one packfile in repo Jiang Xin
2020-12-16 17:32 ` Junio C Hamano
2020-12-17 1:57 ` [PATCH v2] " Jiang Xin
2020-12-17 6:08 ` Junio C Hamano
2020-12-16 18:46 ` [PATCH] " Jeff King
2020-12-16 13:22 ` Daniel Klauer [this message]
2020-12-16 19:00 ` bug report: "git pack-redundant --all" crash in minimize() Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46660c3-630c-5573-9ef4-75d273d37767@web.de \
--to=daniel.c.klauer@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).