From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 884FC1F9FC for ; Mon, 22 Mar 2021 10:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbhCVKHA (ORCPT ); Mon, 22 Mar 2021 06:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbhCVKGj (ORCPT ); Mon, 22 Mar 2021 06:06:39 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE2EC061574 for ; Mon, 22 Mar 2021 03:06:39 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id q5so10594795pfh.10 for ; Mon, 22 Mar 2021 03:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vtOtns4rgYSn8/kHVULWT5G8XKRygCJdSwfCGcxDmtk=; b=AJoNMfl13ZiySyPKmGIMLtPhLODglbnxFszblj8qn388z55zu2FPBMTJDcpHwcd+jg G23aaA9Q82/dU9dxbv0IMM3igfxr1Ary/84chLUFH0btOyh2CJsOc1SWBBSuzGySnuqC PBykyprnOeH2JHOCHwIwD2rAKofqH6V5RNhXu3Ob9LrA88aNLKw19xyHPO1ijTPTBy9d WXxkEIFu210KM1ENb3IVqnxWp176Zhu3mFOcWjQwS2jSgpa/bzKIf4pSw+DYVLWCQzOH b04ma4aDRbBiB5oTL543zOJIL6pYsY/+trPOrZ0vLYwkwGmxsoGPhrqM4IQ0uVtJmtTc syTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vtOtns4rgYSn8/kHVULWT5G8XKRygCJdSwfCGcxDmtk=; b=alp2XvgFSPpBqnVUoGMU/uExSIL3CUHS8tXb4XIWtQExJNX8AtVuqekPK7iaGbuf34 znbjvsq07azLHxVbkqD4vmHzfteCTBLL8V0jqInefdzsRaP9QpsJ9fSHKNpF2IVYKkAs RTIfH0mN9B6kcBN9LtLlIRcBO2+IT1y7INRCXu9vnvK7j2spd6Pg/LiToVlFxP1wg/3W /wupa/PgGyz8sdTbuPF44tjxbZRDltsVfNElN9VV+0bp3gDtMSmQ7qLJidEWI+3gxRy0 Jvdg3xLeD5JkOMNARVP7jYOrdN0fR9s8oXnk8YnjfQeA1zNMCvC0szWRdG6oJNmxUCwu O1Zg== X-Gm-Message-State: AOAM530LF0PtDe1NI4r0JTHY9cXSjk9EwyJD9/zn5MYy7qFBtYmv5fkW 6o1uc9Nz5SVl/6xD4QxZLncJRbe9HmCwvDFd X-Google-Smtp-Source: ABdhPJwZwuDBvoFtcC0RaAB4kqk781cjtMcDTVKLuPv4mgck+2kyUNcnODCaHnyehr5EK2GxRTw7aw== X-Received: by 2002:a63:f247:: with SMTP id d7mr7951604pgk.112.1616407598910; Mon, 22 Mar 2021 03:06:38 -0700 (PDT) Received: from [192.168.43.80] (subs32-116-206-28-58.three.co.id. [116.206.28.58]) by smtp.gmail.com with ESMTPSA id 2sm12919937pfi.116.2021.03.22.03.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 03:06:38 -0700 (PDT) Subject: Re: Blob hash of binary files in patches generated by git format patch show in full form instead of short form From: Bagas Sanjaya To: Junio C Hamano Cc: git@vger.kernel.org References: <499c9922-eb42-c2a8-b4b4-8e5197ea0fc6@gmail.com> <56cde808-95c3-2e22-2dab-880061d51473@gmail.com> Message-ID: Date: Mon, 22 Mar 2021 17:06:35 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <56cde808-95c3-2e22-2dab-880061d51473@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Oh oh oh, I see git diff format for generating patches in documentation for git diff-files. On 22/03/21 12.47, Bagas Sanjaya wrote: > On 22/03/21 00.31, Junio C Hamano wrote: >> Bagas Sanjaya writes: >> >>> What's different between what you expected and what actually happened? >>> >>> Blob hash for binary files are shown in full form, as opposed to blob hash >>> for text files. >> >> This is working as intended, designed and implemented. >> >> The textual patch is meant to be applicable on target text that may >> even have been slightly modified from the original from which the >> patch was taken, and the abbreviated object name on the "index" line >> is there mostly for human's sanity check and as a visual aid. >> Ordinarily it is not used to actually find the matching blob object >> (and it is not an error if there is no matching blob object in the >> repository that a patch application is attempted in). >> >> But the binary patch is designed to be applicable only to an exact >> copy of the original and nowhere else.  The object name is given in >> full, instead of using abbreviated form, to ensure that we do not >> try to apply a binary patch to an object whose name is "similar". >> >> Thanks. >> > > Hmm... but I don't see that in the documentation for git format-patch. > Maybe I need to send doc update. > -- An old man doll... just what I always wanted! - Clara