From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Calum McConnell <calumlikesapplepie@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] Die if filter is attempted without a worktree
Date: Tue, 7 Sep 2021 15:18:08 +0700 [thread overview]
Message-ID: <a20bd60e-7445-131c-e9f3-548bc8dcf1f4@gmail.com> (raw)
In-Reply-To: <20210906181002.625647-2-calumlikesapplepie@gmail.com>
On 07/09/21 01.10, Calum McConnell wrote:
> + /* The results of a nonexistent worktree could be... weird. Lets avoid*/
> + if(dict[1].value == NULL){
> + BUG("There is no worktree for this worktree substitution");
> + }
> +
Why don't simply print that error message without BUG() (aka using
die(_("message"))? It can be l10n-ed if you using the approach.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-09-07 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 18:10 [PATCH 1/3] Add support for new %w wildcard in checkout filter Calum McConnell
2021-09-06 18:10 ` [PATCH 2/3] Die if filter is attempted without a worktree Calum McConnell
2021-09-06 22:09 ` Ævar Arnfjörð Bjarmason
2021-09-07 14:56 ` Calum McConnell
2021-09-07 8:18 ` Bagas Sanjaya [this message]
2021-09-06 18:10 ` [PATCH 3/3] Document the new gitattributes change Calum McConnell
2021-09-07 16:33 ` [PATCH 1/3] Add support for new %w wildcard in checkout filter Jeff King
2021-09-07 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20bd60e-7445-131c-e9f3-548bc8dcf1f4@gmail.com \
--to=bagasdotme@gmail.com \
--cc=calumlikesapplepie@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).