From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Colin Curtis <colinpcurtis@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Add cmd_gud and detect libiconv path for Mac OS
Date: Wed, 8 Sep 2021 13:01:01 +0700 [thread overview]
Message-ID: <a1ba4d11-222a-92a1-257d-522dc4e0d8e0@gmail.com> (raw)
In-Reply-To: <20210908051340.13332-1-colinpcurtis826@ucla.edu>
On 08/09/21 12.13, Colin Curtis wrote:
> From: Colin Curtis <colinpcurtis@gmail.com>
>
> The gud command opens the Pro Git book webpage in the default
> web browser. The reason to add this command is due to the
> play on words when saying 'git gud', which sounds like 'get good'.
> Hence this command when invoked will open up the Pro Git
> webpage to allow the user to 'get good' at git.
>
> We also fix a bug in the Makefile when running on Mac OS, namely
> the libiconv path when using a brew install for the library. Previously
> the developer would have to manually change the path to the library when
> developing on Mac OS.
>
Two distinct topics in one patch series. Why don't you create separate
patch series for each topic?
For `git gud`, I think there's no point on adding such easter egg, since
users can simply access git-scm.com with their browser, without needing
specialized command just to invoke it.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-09-08 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:13 [PATCH 0/2] Add cmd_gud and detect libiconv path for Mac OS Colin Curtis
2021-09-08 5:13 ` [PATCH 1/2] add cmd_gud to open git-scm.com webpage Colin Curtis
2021-09-08 5:13 ` [PATCH 2/2] add liconv link for makefile Colin Curtis
2021-09-08 5:52 ` Carlo Arenas
2021-09-08 6:01 ` Bagas Sanjaya [this message]
2021-09-08 10:50 ` [PATCH 0/2] Add cmd_gud and detect libiconv path for Mac OS Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ba4d11-222a-92a1-257d-522dc4e0d8e0@gmail.com \
--to=bagasdotme@gmail.com \
--cc=colinpcurtis@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).