From: Pratyush Yadav <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, Mark Levedahl <email@example.com>, "brian m. carlson" <firstname.lastname@example.org>, git <email@example.com>, Christian Couder <firstname.lastname@example.org> Subject: Re: [PATCH] git-gui: Perform rescan on window focus-in Date: Sat, 3 Aug 2019 01:43:11 +0530 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 8/2/19 10:17 PM, Junio C Hamano wrote: > Pratyush Yadav <email@example.com> writes: > >> +Junio > > I do not have a strong opinion on this one---a Meh by default means > a moderately strong preference for status-quo. > >> All right, the patch in its current state can't fly. So what is the >> correct way to do this? I see the following options: >> >> 1. Add this as an option that is disabled by default, but people who >> don't mind it can enable it. This is the easiest to implement. But I >> leave it to you and Junio (and anyone else who wants to pitch in :)) >> to decide if it is a good idea. > > I think this is a good first step. As I said already, I am not > convinced that "focus in" is a good heuristics for triggering auto > rescan, and I suspect that you or others may come up with and > replace it with a better heuristic over time. During that > experiment, it would be better to allow interested others to opt > into the feature to help, while not disturbing ordinary users who > are OK with the current behaviour. > All right. I'll look a bit more to see if I can figure something better. I suggested using filesystem watches. I'll wait a bit to hear from Johannes on what he thinks about it. He doesn't like the idea of using Watchman apparently. Otherwise, I'll send in an updated patch with this feature as opt-in. -- Regards, Pratyush Yadav
next prev parent reply other threads:[~2019-08-02 20:13 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-28 15:17 Pratyush Yadav 2019-07-28 21:36 ` brian m. carlson 2019-07-28 22:10 ` Pratyush Yadav 2019-07-28 22:32 ` Pratyush Yadav 2019-07-28 22:49 ` brian m. carlson 2019-07-29 2:24 ` Mark Levedahl 2019-07-29 2:26 ` Mark Levedahl 2019-07-29 2:28 ` Mark Levedahl 2019-07-29 8:15 ` Pratyush Yadav 2019-07-31 19:42 ` Johannes Schindelin 2019-08-01 21:52 ` Pratyush Yadav 2019-08-02 12:39 ` Johannes Schindelin 2019-08-02 20:00 ` Pratyush Yadav 2019-08-03 20:34 ` Johannes Schindelin 2019-08-04 12:53 ` Pratyush Yadav 2019-08-04 19:10 ` Johannes Schindelin 2019-08-04 20:17 ` Pratyush Yadav 2019-08-02 16:47 ` Junio C Hamano 2019-08-02 20:13 ` Pratyush Yadav [this message] 2019-08-04 18:56 ` Johannes Schindelin 2019-07-29 5:09 ` Junio C Hamano 2019-07-29 8:44 ` Pratyush Yadav 2019-07-28 21:44 ` Pratyush Yadav
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] git-gui: Perform rescan on window focus-in' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).