git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] list-objects-filter cleanups
Date: Mon, 19 Sep 2022 13:51:29 -0400	[thread overview]
Message-ID: <a0d692da-9910-9c43-d710-6cfe739ce09e@github.com> (raw)
In-Reply-To: <Yx1qwlpNbxGEiUgc@coredump.intra.peff.net>

On 9/11/2022 12:57 AM, Jeff King wrote:
> In the recent jk/plug-list-object-filter-leaks topic[1], I stopped short
> of fixing all of the callers to actually initialize the filter struct
> beyond zero-ing it.
> 
> This series does the cleanup that I was afraid to do there. :)
> 
> I think the end result is less confusing and error-prone. And as you can
> see in patch 4, it matches how the code originally hoped to be written,
> but the author was also afraid of the zero-initialization thing.
> 
> It is kind of churny, and carries some risk of regression (if I missed a
> spot). IMHO it's worth it, but even if we don't take it, we should pick
> up the first two patches, which are small bug-lets that the conversion
> turned up.

I agree that it's worth it. Hopefully the BUG() you inserted is sufficient
to catch any regression in CI.

Thanks,
-Stolee

      parent reply	other threads:[~2022-09-19 17:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  4:57 [PATCH 0/4] list-objects-filter cleanups Jeff King
2022-09-11  4:58 ` [PATCH 1/4] list-objects-filter: don't memset after releasing filter struct Jeff King
2022-09-12 15:40   ` Junio C Hamano
2022-09-11  5:00 ` [PATCH 2/4] list-objects-filter: handle null default filter spec Jeff King
2022-09-12 16:56   ` Junio C Hamano
2022-09-11  5:03 ` [PATCH 3/4] list-objects-filter: add and use initializers Jeff King
2022-09-11  5:03 ` [PATCH 4/4] list-objects-filter: convert filter_spec to a strbuf Jeff King
2022-09-19 17:50   ` Derrick Stolee
2022-09-19 19:05     ` Jeff King
2022-09-11  5:07 ` [PATCH 0/4] list-objects-filter cleanups Jeff King
2022-09-19 17:51 ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0d692da-9910-9c43-d710-6cfe739ce09e@github.com \
    --to=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).