From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 37E441F910 for ; Wed, 23 Nov 2022 15:09:07 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HniK+r9Z"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238201AbiKWPHu (ORCPT ); Wed, 23 Nov 2022 10:07:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238742AbiKWPHp (ORCPT ); Wed, 23 Nov 2022 10:07:45 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD1606590 for ; Wed, 23 Nov 2022 07:07:43 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id z4so15235598wrr.3 for ; Wed, 23 Nov 2022 07:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=7WJc7Ttpo4NH9FIsogHjOIBOjExfl9UCmhKXAPHK3+A=; b=HniK+r9ZQ+W+NXRpCGhtFXnh5rH98MpYp8Q92BIUhAjCci7YQSwk1/wOk/Fe2Z0xGe 3HN2x4YClfhCjWBdInYoJ+o67oHX2R8YGY/tQ+qGPXSKaEF4uHWgKS6dasQYq/YKx/yT itsE2DwQGpXZJJsHPuHFTMey0pGR12NXnzJeTgIBQQAtKoXk0TKmABBMKdjCxAtxuZ7s ibsFhaJCt5Jm7sWoW2XTZVZWdB8A9ku5BoKZoa3yXGZEEVdFX9KtCVYIKLsBR/YeSD7W REGqTva76uGBJdo2KnYIdJi5At3ejBg8AdpHIAdPIzIWQkiKW/WFAp49slhh3W1SNfAT jCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7WJc7Ttpo4NH9FIsogHjOIBOjExfl9UCmhKXAPHK3+A=; b=wJCwV1Imr8jbreYX530N3wfa67D1/1rNMLFuTm5a41FvQYoWrgEyAl+RSaG/ZXa4e0 DcghFKDHDVkKBs8lDWNA8fNVIjxTNpqNZ9Pycyk01pCIqUr+maE2fu4YCqiEQzRnPGyz /rQW39idcYX38GRjV/IaAjkEpRDAEiOAaUqYgKigfqU74hqxsaUnzjuVeHyOY/ZK+q+g +SOp0hVHDTqrACswUV+qguW+CBqLFaOBknPY/cRc1R3F5DQSYOSpDDivD1FH6eHSQfrk 6WYmn1k9l8aboifJYp7HDAVuG8CoDNaYw8LkRQPeFgP/jsjs/Wa+U5rMI0/e/9ek8RaI 7Kqw== X-Gm-Message-State: ANoB5pmyhhiNhuCm4HQOqq0BDYK92KfoF+ZKYoWr/tGZl46w/gofZ680 4X37u5rfyvgYNAOvHX1khj4= X-Google-Smtp-Source: AA0mqf6zX+g4dd1l3WPGIEbNxsya2xVasvFP2PT55ntCELV3Kg5QOLSpDNpSUcscXfnjQHVTww0Mkg== X-Received: by 2002:a5d:42d0:0:b0:241:d8e2:868d with SMTP id t16-20020a5d42d0000000b00241d8e2868dmr9042460wrr.671.1669216062333; Wed, 23 Nov 2022 07:07:42 -0800 (PST) Received: from [192.168.1.74] ([31.185.185.212]) by smtp.gmail.com with ESMTPSA id e17-20020a05600c4e5100b003a3170a7af9sm2886770wmq.4.2022.11.23.07.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 07:07:41 -0800 (PST) From: Phillip Wood X-Google-Original-From: Phillip Wood Message-ID: Date: Wed, 23 Nov 2022 15:07:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Reply-To: phillip.wood@dunelm.org.uk Subject: Re: [PATCH v2] config: introduce an Operating System-specific `includeIf` condition Content-Language: en-US To: Junio C Hamano , Phillip Wood Cc: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Johannes Schindelin References: <221122.864juraxl2.gmgdl@evledraar.gmail.com> <9c0ecaff-3d66-2b83-eb78-64632d1fcddd@dunelm.org.uk> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Junio Welcome back, I hope you enjoyed your time away from the list. On 23/11/2022 00:16, Junio C Hamano wrote: > Phillip Wood writes: > >> All the other items listed in your table such as branch names are case >> sensitive. The os name is not so it is of no benefit at all to the > > You keep saying that you consider the OS name is case insensitive, > but I doubt that is the case, not in the sense that MacOS and macOS > are two different operating systems, but in the sense that OS > publishers have a single preferred way to spell their ware (which is > shown in "uname -s" output), and we should respect that. I can see that we would want to respect the preferred spelling in our documentation but it seems a bit mean to penalize users who write [IncludeIf "os:windows"] rather than [IncludeIf "os:Windows"] Best Wishes Phillip