From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2024, #10; Mon, 29)
Date: Mon, 29 Apr 2024 20:05:58 +0200 [thread overview]
Message-ID: <Zi_hhpoXHrCz2kcf@tanuki> (raw)
In-Reply-To: <xmqqplu8ulra.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 2011 bytes --]
On Mon, Apr 29, 2024 at 10:22:33AM -0700, Junio C Hamano wrote:
> * ps/the-index-is-no-more (2024-04-18) 6 commits
> - repository: drop `initialize_the_repository()`
> - repository: drop `the_index` variable
> - builtin/clone: stop using `the_index`
> - repository: initialize index in `repo_init()`
> - builtin: stop using `the_index`
> - t/helper: stop using `the_index`
>
> The singleton index_state instance "the_index" has been eliminated
> by always instantiating "the_repository" and replacing references
> to "the_index" with references to its .index member.
>
> Will merge to 'next'?
> source: <cover.1713442061.git.ps@pks.im>
I'd be happy to see it gone as one more step towards less global state.
It may be debatable whether the index should really be contained in
`struct repository`, but even if we ultimately decide that it is not,
dropping `the_index` would be a necessary step into that direction
anyway.
So yeah, I'd be happy to see `the_index` gone. From thereon we can
continue to iterate.
> * ps/reftable-write-optim (2024-04-08) 11 commits
> - reftable/block: reuse compressed array
> - reftable/block: reuse zstream when writing log blocks
> - reftable/writer: reset `last_key` instead of releasing it
> - reftable/writer: unify releasing memory
> - reftable/writer: refactorings for `writer_flush_nonempty_block()`
> - reftable/writer: refactorings for `writer_add_record()`
> - refs/reftable: don't recompute committer ident
> - reftable: remove name checks
> - refs/reftable: skip duplicate name checks
> - refs/reftable: perform explicit D/F check when writing symrefs
> - refs/reftable: fix D/F conflict error message on ref copy
>
> Code to write out reftable has seen some optimization and
> simplification.
>
> Will merge to 'next'?
> source: <cover.1712578837.git.ps@pks.im>
This series has seen reviews and I don't have any remaining things to
address here, so I think it's ready to go.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-29 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:22 What's cooking in git.git (Apr 2024, #10; Mon, 29) Junio C Hamano
2024-04-29 17:45 ` Dragan Simic
2024-04-29 18:05 ` Patrick Steinhardt [this message]
2024-04-30 4:45 ` Linus Arver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi_hhpoXHrCz2kcf@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).