From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7BC481F44D for ; Wed, 10 Apr 2024 09:43:07 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=pks.im header.i=@pks.im header.a=rsa-sha256 header.s=fm2 header.b=L8QCcwDT; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=EKRPjNq2; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CA4AC1C20371 for ; Wed, 10 Apr 2024 09:43:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F34B156881; Wed, 10 Apr 2024 09:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="L8QCcwDT"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="EKRPjNq2" Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42EAB125CD for ; Wed, 10 Apr 2024 09:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712742177; cv=none; b=HSD8f2B8tlYu+W65PLe2om55J9VNDZ0Iy/jlYkFzoHhtwAg55Gyxh2xvOcxWe9mrp/DBrCU3/vsIXLtDULfwVZxEi/Moew7vNu9MVlk/z3qCT0rl06x06XoxaYxeYYxfuBtukKiOKMcs3n99xvJTYhc07F82K2vJRDYV7kwIfdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712742177; c=relaxed/simple; bh=TSfGIcu4Tn6g4TtVPMmDWgT9Q1EdvUTnLHZW8akPfBk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WRNqxxy9x3HeiByQzf/SoVxU8zqeJVGI+L2wqeIY31ZlBW3Ecz0uo7XvXzzft+gb+jzJO1uS8LcMp1f/Vll5n+Z3dd7LyA/oqK4VF5TmJmrfg9T5I9M4RUUa9IECgicsPz4wssGkLVq5Z1/0devLuzYBF2S6+myzUoZfyCHe72E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=L8QCcwDT; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=EKRPjNq2; arc=none smtp.client-ip=103.168.172.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 2B22911401A0; Wed, 10 Apr 2024 05:42:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 10 Apr 2024 05:42:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1712742174; x=1712828574; bh=TSfGIcu4Tn 6g4TtVPMmDWgT9Q1EdvUTnLHZW8akPfBk=; b=L8QCcwDTXsp0acQ7zq1Ui3gZJl zcVql5XArqo64ocDSlh59ZQiTCvQYQmUgkOqjHecFHuTP+C1w4MGP7vKt8fUVUP+ 1SWh1tSkCPEx4/RsBcbKzyVYB0KOTvpDF2sCHKp9ADKK6+0m2MCjoTuErGLWQKSG m8qly0g8TvUhFJgLMEoLNadjGfYAGaLZqLxmmMn1cP04Ec1fW1Omn1xkaB1jDUn9 wHm/KylAGc1nVx3hLGI5VCrIQUPORBLUTldRcALI2oqFMKXFBg/XjEFM3XjY8XLW /Wj/2rzbh2wu+JD4UVlGDa280UWj17APbBykD59A5bh3MIPec+xN4saehUuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712742174; x=1712828574; bh=TSfGIcu4Tn6g4TtVPMmDWgT9Q1Ed vUTnLHZW8akPfBk=; b=EKRPjNq27U+O9u66PrTHG5FhOwKsAMY9rvuiILRocgKm Ix/cZ+2caX8RteaMDMSZpgCzYTBpHRq0/K9Wbki17S3kO0KRahhDHLO73tpJD7a6 ARXTqNxhnYaemIK2ukbKp0ZYF+A14HmsY01ZBa8s87Flxw3PSum/zuq2NqKisK/d O2KjWdrP++r5NH8X1TmNNlwbzoHYixAOlm6+8sYfkQTe/6zS2NJdGMG+zo5kf9rW uCWcaeDiQpgQz33zoZx6FGaItWNVorde1J/L5mnJrzWekQQMw7A/IB8Q1KH0XYCO 12YgcHRREujjC4F9XXUX0jMO5dI4mZEE9gDzcKr0Uw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehiedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepteeuvefhhfdufedvgeeiueeileegtdfhgeeftdeuveejjedtgfejhedujeeutddu necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhsse hpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Apr 2024 05:42:52 -0400 (EDT) Received: by localhost (OpenSMTPD) with ESMTPSA id 6214c3ea (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 10 Apr 2024 09:42:39 +0000 (UTC) Date: Wed, 10 Apr 2024 11:42:47 +0200 From: Patrick Steinhardt To: Thalia Archibald Cc: Chris Torek , git@vger.kernel.org, Elijah Newren Subject: Re: [PATCH v2 1/8] fast-import: tighten path unquoting Message-ID: References: <20240322000304.76810-1-thalia@archibald.dev> <784B5318-F155-4D93-8085-62ACA63432E5@archibald.dev> <6C467327-0DB1-4E1F-8CB5-23DE45271348@archibald.dev> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TKRT0P4y6AuxYG/c" Content-Disposition: inline In-Reply-To: <6C467327-0DB1-4E1F-8CB5-23DE45271348@archibald.dev> --TKRT0P4y6AuxYG/c Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 10, 2024 at 09:14:16AM +0000, Thalia Archibald wrote: > On Apr 10, 2024, at 01:51, Chris Torek wrote: > > On Wed, Apr 10, 2024 at 1:47=E2=80=AFAM Thalia Archibald wrote: > >> strchrnul does what I want here and I=E2=80=99ve replaced it with that. > >=20 > > `strchrnul` is a GNU extension (found on a lot of systems, but not > > part of C90 or C99). >=20 > I can=E2=80=99t speak to Git standards, but it seems broadly used in Git,= including > three times already in fast-import: It's fine to use `strchrnul()` in Git. In case libc doesn't provide it we have a fallback implementation in "git-compat-util.h". Patrick --TKRT0P4y6AuxYG/c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmYWXxIACgkQVbJhu7ck PpQidhAApH9Ff1yCt6LzMwawU22WsJzPNcGW1nPUxMilRU+tm/k/TrNdUbw2yVhF ESP6Z/wJFUfybMGmis1YEFCngZ70P6kHCG3tR1tNPdbY27HZ4HqGpbNSPDx/gbYP XmnQe13f9PI2WUwubKDe2MQPFAPNrdRoJNJN+66RQXt+IaA1oNeUcug4KrsaSzzY 2TUx+1rtV5vZa44P0LrA+KYkrJfTXHFyKQKJ8KdNrkFpsGlAlxzZ3l2Nxa+tFScb Ik7WGhpJDyHBwF3whT5AgDGTf4cGWcPlO4ussENrVEh9IgahE+uPQbCVmqyVJeB3 wvyN4XNAYcsTqR6MTerqV6MOJzmaatrXkOL+pTecIEiFgsN0IfpOqFr31vx3RoU6 kDh6OLY5vkXgIA5g5nsMtwIG++Ue+FVGplD9MljN2tbN236MiHjxfkH03wxObe46 lKwgFnrPNzIpE3WuqGiWhgNvxwMZwo/2PzlAbFaDYjkynhnbiGVrFsNCBUCjx0dk 4H7V+MontwGbPAgLB80wI1i9ADQBiZplTFJh5WCg0v+ePYESrDDf0r6HetMmH4ni 6xMmmlx5SUcKvZ1ZIxiY+R8V1ZtoqzYBba6LXQ2M6/DDeyV2cL5GpA/fIynZwYDH XPEsUWPylcB6TR7FvLNP47iVUeek2DmpxBm/MFceGtAWTjE7L1g= =/v0r -----END PGP SIGNATURE----- --TKRT0P4y6AuxYG/c--