git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] t/t7700-repack.sh: fix test breakages with `GIT_TEST_MULTI_PACK_INDEX=1`
Date: Tue, 2 Apr 2024 16:04:51 -0400	[thread overview]
Message-ID: <Zgxk43ZH6Tz4TnaT@nand.local> (raw)
In-Reply-To: <xmqqh6gj4k04.fsf@gitster.g>

On Tue, Apr 02, 2024 at 12:55:39PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > I would argue that GIT_TEST_MULTI_PACK_INDEX should be on the list of
> > GIT_TEST_-variables to get rid of as it has served its purpose.
> >
> > Like I said, I'd like to get rid of this (and many other)
> > GIT_TEST-related variables, but that is a larger effort than this single
> > patch.
>
> Yup, that sounds like a good longer-term goals.  While it does not
> smell like it is consistent with that goal to add more instances of
> use of it to the test, it may inevitably be a "few steps backward in
> preparation to jump big forward", perhaps.

Yep, exactly.

Thanks,
Taylor


  reply	other threads:[~2024-04-02 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 16:26 [PATCH] t/t7700-repack.sh: fix test breakages with `GIT_TEST_MULTI_PACK_INDEX=1` Taylor Blau
2024-04-02 18:37 ` Junio C Hamano
2024-04-02 18:45   ` Taylor Blau
2024-04-02 19:55     ` Junio C Hamano
2024-04-02 20:04       ` Taylor Blau [this message]
2024-04-02 20:24     ` Jeff King
2024-04-02 22:10       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zgxk43ZH6Tz4TnaT@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).