Re: [RFC][GSoC] Proposal: Move reftable and other tests to the unit testing framework

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

On Wed, Mar 20, 2024 at 02:17:23PM +0100, Christian Couder wrote:
> On Tue, Mar 19, 2024 at 6:11 PM Chandra Pratap
> <chandrapratap3519@gmail.com> wrote:
[snip]
> > A new unit testing framework was introduced to the Git mailing list last
> > year with the aim of simplifying testing and improving maintainability.
> > The idea was accepted and merged into master on 09/11/2023. This project
> > aims to extend that work by moving more tests from the current setup to
> > the new unit testing framework.
> >
> > The SoC 2024 Ideas page (link: https://git.github.io/SoC-2019-Ideas/)
> > mentions reftable unit tests migration as a separate project from the
> > general unit test migration project, however, I propose migrating other
> > tests alongside the reftable unit tests as a part of this proposal.
> 
> It means that if we select your proposal, we cannot select someone
> else to work on either the "Move existing tests to a unit testing
> framework" project or the "Convert reftable unit tests to use the unit
> testing framework" project.
> 
> I am not sure but I think that, after migrating all the reftable unit
> tests, I would prefer you working on other reftable related tasks
> rather than on more unit test migrations.

I agree, I'd also like to keep these projects separate from each other.
Also, the reftable tests could certainly use some polishing and a lot
more documentation than they currently have. Their coding style does not
really match the rest of the project, and if we're busy migrating the
code then I think we should also take the chance and touch it up.

That will require the student to understand the reftable code a whole
lot more deeply than a mere conversion would require though. Thus, I
would like to caution any student who wants to pick up this project to
not underestimate the effort required for this project. The reftable
code itself is certainly non-trivial.

As Chris mentioned, if this project would be finished early I'm quite
sure that the efforts would uncover bugs, test gaps or similar things in
the vicinity of reftables that the student could certainly continue to
work on.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]