From: Max Gautier <mg@max.gautier.name>
To: git@vger.kernel.org
Cc: "Lénaïc Huard" <lenaic@lhuard.fr>, "Derrick Stolee" <stolee@gmail.com>
Subject: Re: [RFC PATCH 3/5] maintenance: use packaged systemd units
Date: Tue, 19 Mar 2024 13:09:32 +0100 [thread overview]
Message-ID: <ZfmAfIErHRZVbd49@framework> (raw)
In-Reply-To: <20240318153257.27451-4-mg@max.gautier.name>
I'm working on updating the test in t7900-maintenance.sh, but I might be
missing something here:
>test_expect_success 'start and stop Linux/systemd maintenance' '
> write_script print-args <<-\EOF &&
> printf "%s\n" "$*" >>args
> EOF
>
> XDG_CONFIG_HOME="$PWD" &&
> export XDG_CONFIG_HOME &&
> rm -f args &&
> GIT_TEST_MAINT_SCHEDULER="systemctl:./print-args" git maintenance start --scheduler=systemd-timer &&
Do I understand correctly that this means we're not actually running
systemctl here, just printing the arguments to our file ?
> # start registers the repo
> git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
>
> for schedule in hourly daily weekly
> do
> test_path_is_file "systemd/user/git-maintenance@$schedule.timer" || return 1
> done &&
> test_path_is_file "systemd/user/git-maintenance@.service" &&
>
> test_systemd_analyze_verify "systemd/user/git-maintenance@hourly.service" &&
> test_systemd_analyze_verify "systemd/user/git-maintenance@daily.service" &&
> test_systemd_analyze_verify "systemd/user/git-maintenance@weekly.service" &&
>
> printf -- "--user enable --now git-maintenance@%s.timer\n" hourly daily weekly >expect &&
> test_cmp expect args &&
>
> rm -f args &&
> GIT_TEST_MAINT_SCHEDULER="systemctl:./print-args" git maintenance stop &&
>
> # stop does not unregister the repo
> git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
>
> for schedule in hourly daily weekly
> do
> test_path_is_missing "systemd/user/git-maintenance@$schedule.timer" || return 1
> done &&
> test_path_is_missing "systemd/user/git-maintenance@.service" &&
>
> printf -- "--user disable --now git-maintenance@%s.timer\n" hourly daily weekly >expect &&
> test_cmp expect args
The rest of the systemd tests only check that the service file are in
XDG_CONFIG_HOME, which should not be the case anymore.
However, the test does not actually check we have enabled and started
the timers as it is , right ?
Should I add that ? I'm not sure how, because it does not seem like the
tests run in a isolated env, so it would mess with the systemd user
manager of the developper running the tests...
Regarding systemd-analyze verify, do the tests have access to the source
directory in a special way, or is using '../..' enough ?
Thanks
--
Max Gautier
next prev parent reply other threads:[~2024-03-19 12:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 15:31 [RFC PATCH 0/5] maintenance: use packaged systemd units Max Gautier
2024-03-18 15:31 ` [RFC PATCH 1/5] maintenance: package " Max Gautier
2024-03-21 12:37 ` Patrick Steinhardt
2024-03-21 13:07 ` Max Gautier
2024-03-21 13:22 ` Patrick Steinhardt
2024-03-21 13:38 ` Max Gautier
2024-03-21 14:44 ` Patrick Steinhardt
2024-03-21 14:49 ` Max Gautier
2024-03-21 14:48 ` Max Gautier
2024-03-18 15:31 ` [RFC PATCH 2/5] maintenance: add fixed random delay to systemd timers Max Gautier
2024-03-21 12:37 ` Patrick Steinhardt
2024-03-21 13:13 ` Max Gautier
2024-03-18 15:31 ` [RFC PATCH 3/5] maintenance: use packaged systemd units Max Gautier
2024-03-19 12:09 ` Max Gautier [this message]
2024-03-19 17:17 ` Eric Sunshine
2024-03-19 18:19 ` Junio C Hamano
2024-03-19 19:38 ` Max Gautier
2024-03-21 12:37 ` Patrick Steinhardt
2024-03-21 13:19 ` Max Gautier
2024-03-18 15:31 ` [RFC PATCH 4/5] maintenance: update systemd scheduler docs Max Gautier
2024-03-21 12:37 ` Patrick Steinhardt
2024-03-18 15:31 ` [RFC PATCH 5/5] DON'T APPLY YET: maintenance: remove cleanup code Max Gautier
2024-03-22 22:11 ` [PATCH v2 0/6] maintenance: use packaged systemd units Max Gautier
2024-03-22 22:11 ` [PATCH v2 1/6] maintenance: use systemd timers builtin randomization Max Gautier
2024-03-22 22:11 ` [PATCH v2 2/6] maintenance: use packaged systemd units Max Gautier
2024-03-23 8:38 ` Eric Sunshine
2024-03-23 9:52 ` Max Gautier
2024-03-22 22:11 ` [PATCH v2 3/6] maintenance: simplify systemctl calls Max Gautier
2024-03-22 23:09 ` Eric Sunshine
2024-03-23 10:25 ` Max Gautier
2024-03-22 22:11 ` [PATCH v2 4/6] maintenance: cleanup $XDG_CONFIG_HOME/systemd/user Max Gautier
2024-03-22 22:38 ` Kristoffer Haugsbakk
2024-03-22 22:43 ` Junio C Hamano
2024-03-23 11:07 ` Max Gautier
2024-03-24 15:45 ` Phillip Wood
2024-03-25 8:36 ` Max Gautier
2024-03-25 16:39 ` Phillip Wood
2024-03-27 16:20 ` Max Gautier
2024-03-22 22:11 ` [PATCH v2 5/6] maintenance: update systemd scheduler docs Max Gautier
2024-03-22 22:11 ` [PATCH v2 6/6] maintenance: update tests for systemd scheduler Max Gautier
2024-03-22 23:02 ` Eric Sunshine
2024-03-23 10:28 ` Max Gautier
2024-03-24 14:54 ` [PATCH v2 0/6] maintenance: use packaged systemd units Phillip Wood
2024-03-24 17:03 ` Eric Sunshine
2024-03-25 10:08 ` phillip.wood123
2024-03-25 8:32 ` Max Gautier
2024-03-25 10:06 ` phillip.wood123
2024-03-25 12:27 ` Max Gautier
2024-03-25 16:39 ` Phillip Wood
2024-03-25 13:45 ` Max Gautier
2024-03-25 16:39 ` Phillip Wood
2024-03-27 16:21 ` Max Gautier
-- strict thread matches above, loose matches on Subject: below --
2024-03-18 15:07 Max Gautier
2024-03-18 15:07 ` [RFC PATCH 3/5] maintenance: use packaged systemd units Max Gautier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfmAfIErHRZVbd49@framework \
--to=mg@max.gautier.name \
--cc=git@vger.kernel.org \
--cc=lenaic@lhuard.fr \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).