From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A537E1F44D for ; Wed, 6 Mar 2024 02:17:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=DLExCc6F; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 90341283193 for ; Wed, 6 Mar 2024 02:17:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3B858D51E; Wed, 6 Mar 2024 02:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="DLExCc6F" Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40029803 for ; Wed, 6 Mar 2024 02:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709691457; cv=none; b=iZ0+GNGZGe3Pxj400y5nTHrVWcbjxVa6Yqe+jH4/F/qhoHc2YlsNz1/HNZUwosulInkrhRgZbURTJEPCjrBs1N12WRC3h6IGn9IqfX5jT5xGlz+2yp1coEijnRcZshfv8j/PdPH5tp6f/fp1g3sXA75Zn+33uV0XCXPty4KL3k4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709691457; c=relaxed/simple; bh=2OlM9Q6beFCz89hYgY/3O0kv8cfHAy2MfKLMufXHIBc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FVI8Oim2OGEPnuSwfIAZJJbOomfqRYMtcE5Vl5VNw6O6XwZez8e/K8PyT5RJ+xpah8Zam0sP7Rq/dnZUbWw5VnZ4mbKlDtLczUSw8oaUyalh+v5ZAvC4aNhwbcpNEKNTrGi3b1eGI1VK69WtzckFSu03t2xsuVXFrFx2NmWahkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=DLExCc6F; arc=none smtp.client-ip=64.147.108.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E05B71DE1EF; Tue, 5 Mar 2024 21:17:34 -0500 (EST) (envelope-from tmz@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:message-id:references:mime-version:content-type :in-reply-to; s=sasl; bh=2OlM9Q6beFCz89hYgY/3O0kv8cfHAy2MfKLMufX HIBc=; b=DLExCc6FuCPZemAib26M+jdLt2EvpA8BmClUFxSeGkONfhR5sFG0EBo ZoAP/hkfSQNPojkbm4U96HOQ432PuRaQ7nE9eQL3m0eD9v8eI+QBjuK8tr8glYsA y+e3dsPC7u2yZg2rMUhM3Vp4IpTFS91YM/0bgfK5CoTkpIyx6XaI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D8F661DE1ED; Tue, 5 Mar 2024 21:17:34 -0500 (EST) (envelope-from tmz@pobox.com) Received: from pobox.com (unknown [108.15.224.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4D7A61DE1EB; Tue, 5 Mar 2024 21:17:34 -0500 (EST) (envelope-from tmz@pobox.com) Date: Tue, 5 Mar 2024 21:17:32 -0500 From: Todd Zullinger To: Junio C Hamano Cc: Beat Bolli , git@vger.kernel.org, Beat Bolli Subject: Re: [PATCH 19/22] t/t8*: merge "grep | sed" pipelines Message-ID: References: <20240305212533.12947-1-dev+git@drbeat.li> <20240305212533.12947-20-dev+git@drbeat.li> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Pobox-Relay-ID: B1A2C92A-DB5F-11EE-9667-78DCEB2EC81B-09356542!pb-smtp1.pobox.com Junio C Hamano wrote: > Isn't -E a GNUism? > > At least, > > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html > > does not seem to have it (we may need to fix t6030 to rid its only > existing use). I _thought_ that -r was the GNUism. The GNU sed-4.8 manpage says: -E, -r, --regexp-extended use extended regular expressions in the script (for portability use POSIX -E). That doesn't mean the man page is right, of course. :) https://www.austingroupbugs.net/view.php?id=528 suggests that -E has been adopted and, importanly, is more widely supported than -r (if we were considering using that rather than rewriting this to not use ERE syntax). MacOS in particular supports -E but not -r, according to that link. It seems like the documentation hasn't quite caught up to reality yet, perhaps? -- Todd