From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EB9FB1F406 for ; Mon, 30 Oct 2023 19:32:38 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Hb9QTndd; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4B6AC1C20A3F for ; Mon, 30 Oct 2023 19:32:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B8491A704; Mon, 30 Oct 2023 19:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.b="Hb9QTndd" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A8719BCC for ; Mon, 30 Oct 2023 19:32:29 +0000 (UTC) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 597EBA9 for ; Mon, 30 Oct 2023 12:32:28 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-41cc7b67419so36136101cf.2 for ; Mon, 30 Oct 2023 12:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20230601.gappssmtp.com; s=20230601; t=1698694347; x=1699299147; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DH8yZlqqk0pdFBWhp+kt6qgUQ4gWDRC2AxWrgPzU8DY=; b=Hb9QTnddX4xQB8NpxGlaTMrd5YD08ktXUWMQJnhft3y0k5kRcQRtF9jtf4zv/NvLlV E335AGBWOpYfxB+ZnoOaNFvlclh+0rrkd3G3JLMwTbUd5jfgJeT753zVUvVrND55UIyb 5kV6CW1E6zi8cW0vnKrdQ5HfAygyeq8L5hjMXM/Coag8xlEKbG595b9sdilSUqSaNSSK VyRHwKrkrOZn5LhryFdfuS2e+JAxjw1hmhp7MUnaOASAtRWg4vAeiB3V/pgQUxbNDDQC 89DmFD+qgJxds8GHO/dAqnFGpKhg+KxTB5YhvEBTv4RzMNcGfzNRe/yClWRKxkeMMFO2 Vcug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698694347; x=1699299147; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DH8yZlqqk0pdFBWhp+kt6qgUQ4gWDRC2AxWrgPzU8DY=; b=vJTpxbb9Oe+i0EwsRVWxngobLE1Asy/s11unB3P+/cXmstr01wteiz4Pn7FOkzYTR7 1zzBQJq3EDJFMn0pnTPRV49qiS6AXOjt8zxblMOri3H5t/51ioVTShMOIpoEWybzYfy7 pKjHDiC6GOq1O4IeUjyWzPhR3UY/ZwQy5k+9lPRfzmMZgB4/9l2xTUL2wqv2CRHA8sYh PXv1bn1E/di0q5OauhjQRLFv0VOFNSEgjdKcyhixjWAOVsq6PSKfzYZY2YPKD9aZq3aa RCekcSZBqXyVLX0AiRzXeJ/y/FnQu4/eEeCzIFWiVHE2yd0pLkuf0fd5yxLhn+LkTvMY MYPw== X-Gm-Message-State: AOJu0Yza2CDozKPqC/kHe2KWCxTiDb/64bE0KTqLQWUrzctLEEBy+Kf9 sUX7AVaAImlnxvsYEVYAUBEFpA== X-Google-Smtp-Source: AGHT+IGzsZwIhn34gu6eyTqy57bwqqPxl3s//uJ1uMj2SxyR+d8jhAUXdjnWYmmHK2vw/7GFOYvFyQ== X-Received: by 2002:a05:622a:b:b0:412:cd66:f65d with SMTP id x11-20020a05622a000b00b00412cd66f65dmr13354433qtw.13.1698694347487; Mon, 30 Oct 2023 12:32:27 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id g10-20020ac8480a000000b004033c3948f9sm3662834qtq.42.2023.10.30.12.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 12:32:27 -0700 (PDT) Date: Mon, 30 Oct 2023 15:32:25 -0400 From: Taylor Blau To: Patrick Steinhardt Cc: git@vger.kernel.org, Junio C Hamano , Eric Sunshine , Han-Wen Nienhuys Subject: Re: [PATCH v2 00/12] show-ref: introduce mode to check for ref existence Message-ID: References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Unsubscribe-Post: List-Unsubscribe=One-Click On Thu, Oct 26, 2023 at 11:56:16AM +0200, Patrick Steinhardt wrote: > Hi, > > this is the second version of my patch series that introduces a new `git > show-ref --exists` mode to check for reference existence. All looks quite reasonable to me. I'm happy with this series as-is, though I left a few minor comments and suggestions throughout. Thanks, Taylor