From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AF84C1F406 for ; Sat, 11 Nov 2023 01:34:16 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=2HkJCGy8; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 11C921C20966 for ; Sat, 11 Nov 2023 01:34:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58A7F33C8; Sat, 11 Nov 2023 01:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.b="2HkJCGy8" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C19E28F3 for ; Sat, 11 Nov 2023 01:34:06 +0000 (UTC) Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89C42422D for ; Fri, 10 Nov 2023 17:34:04 -0800 (PST) Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-45da601e6f9so1175274137.0 for ; Fri, 10 Nov 2023 17:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20230601.gappssmtp.com; s=20230601; t=1699666443; x=1700271243; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AgUmLoQ30YxbACnJaMgyOKDFPqaNuqL4tQgghgld4b8=; b=2HkJCGy8NUI1MTkVQZ306eUfWRQ43dVOBx5GcbUWkD6gndm6kOdnSpeme8Yykuql8u vC7tVzlOY1+s2bEYYppc2dDuOwSKfgnIntF/dyaMBFFuVYNK3Z0i2miiOWOB0Zl7DZ9u 8hpXts+j6KylLA+Q2jRW/HuQLfJqbNbVwl0as9KjY/M3CK/CgYxxcE1/KGbwlquJnKcY DDuJOcca5TQlpyB/OOOK70kTw0yVlrJwFhrqGiUbFOrGmu+LFtW3fv4xdqye/8mFHTJG A7wfI/7MG+iLEyAZolXORuCpbXeY2PmWiAAlOic4l1rwJzMsBKBRGW0DmRvkaCLT7dju 5WIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699666443; x=1700271243; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AgUmLoQ30YxbACnJaMgyOKDFPqaNuqL4tQgghgld4b8=; b=PQ6adwrJPuhphgxzsidWYFHMsgdAxdlVU/loA1R+8uK1J5Nbh8orV2niP8/OXAiRjO 2V8T7D206V7ZBCL6iWbhbgOQOH7uOn0LQVdgKo5/uSI+rrpfxtWzA9/KaQJQqRVNu4O8 CzNIzXLArlMI4seIUrQ2grSceeBtgJdwNx3kRBPQKfcJlbLwI0qfq+98UdbCgSUE8EfS ACvUc+1LWprrq5aQzU9VFGzDYJS3+AQPMp7y/nhjY0g/Az7rHswtxqVX1YpyjDTG9NUZ 7njO2gAB3/byDv/s/rMbRgMtyaS1UrUyOgdpnjWJ82GkShf6jgZsGx9pxVF1e4VtE5JM ZPCQ== X-Gm-Message-State: AOJu0Ywv4W5d3uIrJyNfrgOYXMnMjKKlP9scs5xm/yxOTydXA4X2NjVf kQ2HK9Px6/f/T299lDkvhxopsjDoZmWUJQGhCixyTA== X-Google-Smtp-Source: AGHT+IEc0AnznCmyRR52rW9fpwcNKns/zvT6Dq+dpff4bG3UrJKzsnM8VbzWIpZ+jFKsaB0/XD3f3g== X-Received: by 2002:a67:c305:0:b0:45d:9abe:b33f with SMTP id r5-20020a67c305000000b0045d9abeb33fmr1078146vsj.31.1699666443602; Fri, 10 Nov 2023 17:34:03 -0800 (PST) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id z6-20020a0ce606000000b0067101efa98asm250248qvm.69.2023.11.10.17.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 17:34:03 -0800 (PST) Date: Fri, 10 Nov 2023 20:34:02 -0500 From: Taylor Blau To: Junio C Hamano Cc: Elijah Newren , git@vger.kernel.org, "Eric W. Biederman" , Jeff King , Patrick Steinhardt Subject: Re: [PATCH v5 5/5] builtin/merge-tree.c: implement support for `--write-pack` Message-ID: References: <3595db76a525fcebc3c896e231246704b044310c.1698101088.git.me@ttaylorr.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Unsubscribe-Post: List-Unsubscribe=One-Click On Sat, Nov 11, 2023 at 09:27:42AM +0900, Junio C Hamano wrote: > Elijah Newren writes: > > > I believe the above is built on an assumption that any objects written > > will not need to be read until after the merge is completed. And we > > might have a nesting issue too... > > ... > > This is unsafe; the object may need to be read later within the same > > merge. > > Thanks for a good analysis. I agree. Ditto. I responded to Elijah more in-depth elsewhere in the thread, but I think for your purposes it is OK to discard this series. Thanks, Taylor