From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: X-Spam-Status: No, score=1.7 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, LIST_MIRROR_RECEIVED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9AFD21F406 for ; Fri, 20 Oct 2023 10:48:14 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9821D1C20F8E for ; Fri, 20 Oct 2023 10:48:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D25F18AF2; Fri, 20 Oct 2023 10:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4562018029 for ; Fri, 20 Oct 2023 10:48:03 +0000 (UTC) Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 268AC1BE7 for ; Fri, 20 Oct 2023 03:45:48 -0700 (PDT) Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id E824E23F67; Fri, 20 Oct 2023 06:45:43 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.6-dev, from userid 1000) id 1qtn0h-t9w-00; Fri, 20 Oct 2023 12:45:43 +0200 Date: Fri, 20 Oct 2023 12:45:43 +0200 From: Oswald Buddenhagen To: Jeff King Cc: Michael Strawbridge , Junio C Hamano , Bagas Sanjaya , Git Mailing List Subject: Re: [PATCH 2/3] Revert "send-email: extract email-parsing code into a subroutine" Message-ID: References: <20231020100343.GA2194322@coredump.intra.peff.net> <20231020101310.GB2673716@coredump.intra.peff.net> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20231020101310.GB2673716@coredump.intra.peff.net> List-Unsubscribe-Post: List-Unsubscribe=One-Click On Fri, Oct 20, 2023 at 06:13:10AM -0400, Jeff King wrote: >But one thing that gives me pause is that the neither before or after >this patch do we handle continuation lines like: > > Subject: this is the beginning > and this is more subject > >And it would probably be a lot easier to add when storing the headers in >a hash (it's not impossible to do it the other way, but you basically >have to delay processing each line with a small state machine). > that seems like a rather significant point, doesn't it? >So another option is to just fix the individual bugs separately. > ... so that seems preferable to me, given that the necessary fixes seem rather trivial. > I guess "readable" is up for debate here, but I find the inline handling > a lot easier to follow > any particular reason for that? > (and it's half as many lines; most of the diffstat is the new tests). >- if ($parsed_email{'From'}) { >- $sender = delete($parsed_email{'From'}); >- } this verbosity could be cut down somewhat using just $sender = delete($parsed_email{'From'}); and if the value can be pre-set and needs to be preserved, $sender = delete($parsed_email{'From'}) // $sender; but this seems kind of counter-productive legibility-wise. regards