From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6BD5C1F406 for ; Mon, 30 Oct 2023 18:24:32 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=AG/QrPN3; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 35BDD281637 for ; Mon, 30 Oct 2023 18:24:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F8C119BBA; Mon, 30 Oct 2023 18:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.b="AG/QrPN3" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5658616408 for ; Mon, 30 Oct 2023 18:24:24 +0000 (UTC) Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F07C1 for ; Mon, 30 Oct 2023 11:24:23 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-581de3e691dso2778840eaf.3 for ; Mon, 30 Oct 2023 11:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20230601.gappssmtp.com; s=20230601; t=1698690262; x=1699295062; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1mSmgoCDfib66rmVubgH5eYXN6J6TqiHxMYQCt+ZPo=; b=AG/QrPN3FphDPu956joTHKx+zxdM8UCcSGIF/OadReSkM/d/xrLhqRiZdE+ceF4mIg TnGZPUz+VlNxXMymsw8+uUxBYqfywD5uEOhmqRNNDr1qlk624mMYsUv8S67/wbxrH9gZ v7PgrVQd3kdB+BQc12pyH6z81x/9S9RM378yaYri0VlmNXiV+EiyromSdbXhbvGwLSZb VMO0wLa4OWYCUyay6K7+ODLclk8gxa+WzIOC7XI11TMXeKTh2Jkes9UxfakaDqUKgC/l sIWufxT1t/wRUENVH3S2HLCh+WsI0RFq/F1RU8x3wTnJTJc70zELOvLp8t1PMkHbTu4R 5FGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698690262; x=1699295062; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1mSmgoCDfib66rmVubgH5eYXN6J6TqiHxMYQCt+ZPo=; b=rVuxu1iAMBHij4ZoRZp+vvXXDe/r7rOm/1fsTMyfVi8LlTVTA+fKVuiz2F0IemLEJJ LWQK90bBxwQDY+uHAE2IOmyYjxIzDhMWjBdMSCSXg0X4ZxZYWNa3rNIH4zw7BdP3R1gQ i2P54XFJI+Owq/Pqr0SKAoby2pXreNM/JmhWazO+U83zfant7kH4Rtn0DjYtFIyToxKr vKwvjTCr6Hjw2B/sQAgTU4Qx8PO13xzQiWZVLqpFXViWj+tYq+CCjE2FDjlz6FE23wQf 7VVgEiCeXg7HgQ+OaO2caHuu0F59W+rms3570Vcy/6oxyvX1GOH0CFqU45Y5BICt8uML uUnw== X-Gm-Message-State: AOJu0YwUfyXUJmLywlVJQco2nsCzoNvEkJ1JAp3W85oIqGekMM8H/dN4 DmrOI2TMx4CskoH08GQPeAT+Iw== X-Google-Smtp-Source: AGHT+IHlWrtulRxTQ0m0DVaS8OlM/ZduFQ32SXaiVe3IDzI5i0kBedtmbiAzaU9EZ7VUs6MNz8y4Tw== X-Received: by 2002:a05:6358:904c:b0:168:dbac:b94e with SMTP id f12-20020a056358904c00b00168dbacb94emr13546851rwf.32.1698690262587; Mon, 30 Oct 2023 11:24:22 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id cs11-20020ad44c4b000000b0065b29403540sm2399575qvb.127.2023.10.30.11.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 11:24:22 -0700 (PDT) Date: Mon, 30 Oct 2023 14:24:21 -0400 From: Taylor Blau To: Patrick Steinhardt Cc: git@vger.kernel.org, Junio C Hamano , Eric Sunshine , Han-Wen Nienhuys Subject: Re: [PATCH v2 04/12] builtin/show-ref: fix dead code when passing patterns Message-ID: References: <87afcee830caab2782ce693c1f961df6fea6e7b5.1698314128.git.ps@pks.im> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87afcee830caab2782ce693c1f961df6fea6e7b5.1698314128.git.ps@pks.im> List-Unsubscribe-Post: List-Unsubscribe=One-Click On Thu, Oct 26, 2023 at 11:56:33AM +0200, Patrick Steinhardt wrote: > When passing patterns to `git show-ref` we have some code that will > cause us to die if `verify && !quiet` is true. But because `verify` > indicates a different subcommand of git-show-ref(1) that causes us to > execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the > condition cannot ever be true. > > Let's remove this dead code. Makes sense. Let's read on... Thanks, Taylor