From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C115C1F454 for ; Tue, 10 Oct 2023 14:11:14 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=joshtriplett.org header.i=@joshtriplett.org header.a=rsa-sha256 header.s=fm1 header.b=NaYBhhF9; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=SroXP28L; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjJJOKp (ORCPT ); Tue, 10 Oct 2023 10:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232455AbjJJOKo (ORCPT ); Tue, 10 Oct 2023 10:10:44 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B6BDA9 for ; Tue, 10 Oct 2023 07:10:42 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6A1FC5C01F1; Tue, 10 Oct 2023 10:10:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 10 Oct 2023 10:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1696947041; x=1697033441; bh=Tt0BsYA65dQ2WB7is9hudrEXBfeHJW9hD0R X5mZ+F9Q=; b=NaYBhhF9dliIdMUQxoZ+wHFa/8nyxnBChxprIYvI+NXnqsTLENe FA3S9MT3Fp4wvxX07Ijxaqg19JWPGglNlvjn6iljFWZIR/jymLzwlOxwMyjO/GMS dMqrNm1lp6ob2xRY7+vtDtkX/yPuikiADnSUpOGr4P8vGD9IBnWNhz/b3J6d204b Qj4T5H3LneGIdbpB3ahl2EjxHED87V2d2Rm8LZPBpblC7gTpyHvtDZwHg2DKoDF6 3nCsYgMllInYDC6sN7Hft+KhuFyuY0f+k5DFCwublD0qnmxPXcWxMQlsfxtsxpTc j7SWcOfyKtK4olp3K2fz5Ls72Xw839pcN9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696947041; x=1697033441; bh=Tt0BsYA65dQ2W B7is9hudrEXBfeHJW9hD0RX5mZ+F9Q=; b=SroXP28LaIGEt6oCOyiBRqxv11LJ1 pHGEKQfCnAufEzhTlGdM9iCLf9ZcIGQiq3KyAA5haIZitiWr9gJC2O2VXQhW1XEP KWSjDRuvhGOOnQP9wqnnW/TjoOLKhgkuFa5EkE+UoaWryaf8VSLsHPBx5vc0RLmw srDmFukiw8ONfOiydVUVycHZdRGI2qdPumuOr8wYz9gv25Ln/cXsGirNdiyj6xFT aOFH6ci6QnYbMJWgedr+r0HENMYdLNk5Kv1t9LF8Ow3p2QvogON9Nv8l52OYyM9V RPO4HekkaGR9Rz6jJVADHcCpxxDDvdanFHapGecr23Ylh2wFj95LEoAgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheehgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeflohhshhcu vfhrihhplhgvthhtuceojhhoshhhsehjohhshhhtrhhiphhlvghtthdrohhrgheqnecugg ftrfgrthhtvghrnhepudeigeehieejuedvtedufeevtdejfeegueefgffhkefgleefteet ledvtdfftefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepjhhoshhhsehjohhshhhtrhhiphhlvghtthdrohhrgh X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Oct 2023 10:10:39 -0400 (EDT) Date: Tue, 10 Oct 2023 22:10:25 +0800 From: Josh Triplett To: Kristoffer Haugsbakk Cc: Sebastian Thiel , git@vger.kernel.org Subject: Re: [RFC] Define "precious" attribute and support it in `git clean` Message-ID: References: <79901E6C-9839-4AB2-9360-9EBCA1AAE549@icloud.com> <98387b86-1732-42bc-9ac5-d64a6617b2db@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98387b86-1732-42bc-9ac5-d64a6617b2db@app.fastmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 10, 2023 at 03:38:51PM +0200, Kristoffer Haugsbakk wrote: > Hi Sebastian > > On Tue, Oct 10, 2023, at 14:37, Sebastian Thiel wrote: > > This highlights precious files by calling them out, but doesn't change the > > behaviour of existing flags. Instead, the new flag `-p` is added which lets > > `git clean` spare precious files. > > Why can't `clean` preserve precious files by default? And then delete them > as well with something like `--no-keep-precious`? Is there some backwards > compatibility concern? While I'd love for it to default to that and require an extra option to clean away precious files, I'd expect that that would break people's workflows and finger memory. If someone expects `git clean -x -d -f` to clean away everything, including `.config`, and then it leaves some files in place, that seems likely to cause problems. (Leaving aside that it might break scripted workflows.) It seems safer to keep the existing behavior for existing options, and add a new option for "remove everything except precious files".