From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Oct 2023, #03; Fri, 6)
Date: Mon, 9 Oct 2023 14:13:56 -0400 [thread overview]
Message-ID: <ZSRC5IaKoXPpTFnq@nand.local> (raw)
In-Reply-To: <xmqqfs2j1xdo.fsf@gitster.g>
On Mon, Oct 09, 2023 at 11:09:07AM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > On Sat, Oct 07, 2023 at 01:20:02AM -0700, Junio C Hamano wrote:
> >> * tb/repack-max-cruft-size (2023-10-05) 4 commits
> >> (merged to 'next' on 2023-10-06 at b3ca6df3b9)
> >> + builtin/repack.c: avoid making cruft packs preferred
> >> + builtin/repack.c: implement support for `--max-cruft-size`
> >> + builtin/repack.c: parse `--max-pack-size` with OPT_MAGNITUDE
> >> + t7700: split cruft-related tests to t7704
> >>
> >> "git repack" learned "--max-cruft-size" to prevent cruft packs from
> >> growing without bounds.
> >>
> >> Will merge to 'master'.
> >> source: <cover.1696293862.git.me@ttaylorr.com>
> >> source: <035393935108d02aaf8927189b05102f4f74f340.1696370003.git.me@ttaylorr.com>
> >
> > Thanks. On a semi-related note, did you want to pick up my patch in
> >
> > https://lore.kernel.org/git/035393935108d02aaf8927189b05102f4f74f340.1696370003.git.me@ttaylorr.com/
> >
> > ? That should address a performance bug that occurs when a repository
> > (incorrectly) chooses a cruft pack as its preferred pack source when
> > writing a MIDX bitmap, significantly impeding the pack-reuse mechanism.
>
> Isn't that in the above list already as b3ca6df3b9^2?
Oops, duh. I hadn't expected you to group that patch in with the rest of
tb/repack-max-cruft-size.
I'll put on my glasses the next time before suggesting you dropped one
of my patches on the floor... ;-)
Thanks,
Taylor
next prev parent reply other threads:[~2023-10-09 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 8:20 What's cooking in git.git (Oct 2023, #03; Fri, 6) Junio C Hamano
2023-10-08 17:34 ` René Scharfe
2023-10-09 16:35 ` Junio C Hamano
2023-10-28 12:02 ` René Scharfe
2023-10-09 9:59 ` Phillip Wood
2023-10-09 16:16 ` Taylor Blau
2023-10-09 18:09 ` Junio C Hamano
2023-10-09 18:13 ` Taylor Blau [this message]
2023-10-09 21:07 ` Junio C Hamano
2023-10-10 20:36 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSRC5IaKoXPpTFnq@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).