From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 0329B1F406 for ; Wed, 9 Aug 2023 21:15:59 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20221208.gappssmtp.com header.i=@ttaylorr-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=rf4LLiau; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbjHIVPx (ORCPT ); Wed, 9 Aug 2023 17:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbjHIVPw (ORCPT ); Wed, 9 Aug 2023 17:15:52 -0400 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F5C610DC for ; Wed, 9 Aug 2023 14:15:52 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-583fe10bb3cso3936527b3.2 for ; Wed, 09 Aug 2023 14:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20221208.gappssmtp.com; s=20221208; t=1691615751; x=1692220551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P2Rvq6VGsf30hoiaNX+WfZMfYxBVlt4MMsTZv6a0JQI=; b=rf4LLiau7XbTcw/k/AA/rrdRcLWi91Bm1Epvr27HWI62R/dXzzLAu8fs2nhcjmDNDc Ednk91ePf8Tede37dofJlaeF9uIHxjoZiJt6AJJphsR3VSlzXvYNZBeSgFdF/auBPKIO hUO5ECSFNz72f7POrZA2F4neW8zvILE/X+NgnPqZWR/iNKwaJLfMtPCcIvH0FU/XKDcK gU7KKqQ7qzbg++msX+8ct6z61oPTJ2atvZUHsdpeUASQ37RBk49fZsLH/sD8OG10obOO exapfKwcftJz6wq62Tyo8f8DnZix40QDQ+dIJHLlpcXhwIcUizmpMoadtEgxDGPQrn1F GkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691615751; x=1692220551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P2Rvq6VGsf30hoiaNX+WfZMfYxBVlt4MMsTZv6a0JQI=; b=NuuTWf1+LYUZCQDfar6BXAuwdhj5nqJQz6WN7m1WBMLxhJgHwJ6EJzS5wFEXekDrey JflC6mVnnp4YWMp0L72DKeLs8JzNLVNJOj+5QMDySv+Eusf8DgJeTn91GKSdqxe2iT2n V6l1oUlILYqfOfvUK19Vx5s6qyefHsmRn66tBw+9bEb1gOYtbnHJQeVatdiHh9NNo02Z uu10WfqVLomuGJ+UAzGdZw31HXDBkDrmA6gc0wn+SpDlyg/b2jCP2MCe1uIWXldwrhXB 1d8Wj1esoAB8QQdaErSG5aKsO1SKDcaTDOZnMJ4dtjJF+InR7Q4Gxt1QaEO3QJ4SLeTP ZB3Q== X-Gm-Message-State: AOJu0Yxxp6XROKiUIwgwSLN82k6iMz3zs4dZwtwGx1JG4q/hgZ4IfE/u wcy0sT2o1a4ujtQM60pPtVD6qw== X-Google-Smtp-Source: AGHT+IGKj1RMe5m1iCAPy+2L2+E2QhLjb6heajcu+dAF5J8cAm5AQh2HiBztXwEoIi+6Qz7moL1n6A== X-Received: by 2002:a81:de54:0:b0:57a:897e:abce with SMTP id o20-20020a81de54000000b0057a897eabcemr545699ywl.7.1691615751282; Wed, 09 Aug 2023 14:15:51 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id y74-20020a81a14d000000b0056d51c39c1fsm4160055ywg.23.2023.08.09.14.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 14:15:50 -0700 (PDT) Date: Wed, 9 Aug 2023 17:15:49 -0400 From: Taylor Blau To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , John Cai , Jonathan Tan , Jonathan Nieder , Derrick Stolee , Patrick Steinhardt , Christian Couder Subject: Re: [PATCH v3 6/8] gc: add `gc.repackFilter` config option Message-ID: References: <20230705060812.2865188-1-christian.couder@gmail.com> <20230724085909.3831831-1-christian.couder@gmail.com> <20230724085909.3831831-7-christian.couder@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Aug 08, 2023 at 10:38:26AM +0200, Christian Couder wrote: > > I may be missing something, but what happens if the user has configured > > gc.repackFilter, but passes additional filters over the command-line > > arguments? I'm not sure whether these should be AND'd with the existing > > filters in config, or if they should reset them to zero, or something > > else. > > `git gc` doesn't recognize `--filter=<...>` arguments, only `git > repack` is being teached to recognize it in this patch series. So I > don't see how there could be multiple such arguments on the command > line when `git gc` is used. > > Also in version 4 `git repack` can be passed many such arguments > anyway. So I think we are good. Ah, thanks. Sorry for the misunderstanding :-). > We could support multiple gc.repackFilter config options, but on the > other hand using something like > `combine:++...` should work, as the content > of the option is passed as-is to the command line. So we can leave > that improvement for later if people don't like the `combine:...` and > are interested in it. I agree. To me it seems like there are probably relatively few people who would want to specify a multi-valued configuration directly when they could just use the "combine" trick you suggest. In either case, I agree that it can be done on top later. Thanks, Taylor