From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 189A91F542 for ; Wed, 17 May 2023 17:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbjEQRCi (ORCPT ); Wed, 17 May 2023 13:02:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjEQRCf (ORCPT ); Wed, 17 May 2023 13:02:35 -0400 Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39F2D9E for ; Wed, 17 May 2023 10:02:34 -0700 (PDT) Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id E64FD23F67; Wed, 17 May 2023 13:02:32 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1pzKXo-KbD-00; Wed, 17 May 2023 19:02:32 +0200 Date: Wed, 17 May 2023 19:02:32 +0200 From: Oswald Buddenhagen To: phillip.wood@dunelm.org.uk Cc: git@vger.kernel.org, Junio C Hamano , Kristoffer Haugsbakk Subject: Re: [PATCH v2] sequencer: beautify subject of reverts of reverts Message-ID: Mail-Followup-To: phillip.wood@dunelm.org.uk, git@vger.kernel.org, Junio C Hamano , Kristoffer Haugsbakk References: <20230428083528.1699221-1-oswald.buddenhagen@gmx.de> <3f5e4116-54e6-9753-f925-ed4a9f6e3518@gmail.com> <2d416834-ef3e-01a2-6be0-9e88bc0de25e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2d416834-ef3e-01a2-6be0-9e88bc0de25e@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 17, 2023 at 12:20:03PM +0100, Phillip Wood wrote: >I'm saying that reverting a commit with a subject line > > Revert "Revert "Revert some subject"" > >should result in the new commit having the subject > > Revert "Revert "Revert "Revert some subject""" > >(i.e. at that point we stop trying to be clever) rather than > > Revert "Reapply "Revert some subject"" > right. how about filing that under GIGO and extending the comment? i mean, when you actually run into this situation, you should be re-thinking your life choices rather than stressing about git producing a somewhat suboptimal commit message template ... regards, ossi