From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Josh Steadmon <steadmon@google.com>,
git@vger.kernel.org, chooglen@google.com
Subject: Re: [PATCH v3] setup: trace bare repository setups
Date: Mon, 8 May 2023 18:31:45 -0400 [thread overview]
Message-ID: <ZFl4UVhoR4Hlm2g3@nand.local> (raw)
In-Reply-To: <xmqqa5yicsxd.fsf@gitster.g>
On Fri, May 05, 2023 at 03:30:38PM -0700, Junio C Hamano wrote:
> Thanks. We saw no interest on the list in reviewing this patch
> further, it seems, but I didn't see anything glaringly wrong, see
> no reason not to merge it, and this should help noticing potential
> issues by $corp folks, I would presume, so let's merge it as-is.
I took a look through this thread and would be fine to see this one
picked up, though I did have a couple of questions:
- Is the plan to eventually disable $GIT_DIR discovery in bare
repositories by default in a future version? I am still uncertain
of the assumption that most end-users don't interact with bare
repositories directly.
Certainly forges touch bare repositories without always setting
$GIT_DIR in their environment. But I would imagine that other tools
indirectly touch bare repositories on behalf of the user. You
mentioned "go" as one such tool that doesn't set $GIT_DIR, I imagine
there are many more.
- If it is the plan to disable $GIT_DIR discovery in bare repositories
in the future, I'm not sure how visible the extra trace line would
be. Perhaps that is desirable, since having an advise() call on
every Git invocation in a bare repository would be noisy.
Thanks,
Taylor
next prev parent reply other threads:[~2023-05-08 22:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 22:32 [PATCH] setup: trace bare repository setups Josh Steadmon
2023-04-27 22:54 ` Junio C Hamano
2023-04-28 16:54 ` Josh Steadmon
2023-04-28 17:01 ` Josh Steadmon
2023-04-28 20:26 ` Junio C Hamano
2023-05-01 17:20 ` Josh Steadmon
2023-05-08 22:19 ` Glen Choo
2023-04-27 23:36 ` Glen Choo
2023-04-28 16:48 ` Josh Steadmon
2023-04-28 17:22 ` [PATCH v2] " Josh Steadmon
2023-04-28 18:37 ` Glen Choo
2023-05-01 17:22 ` Josh Steadmon
2023-05-01 17:30 ` [PATCH v3] " Josh Steadmon
2023-05-05 22:30 ` Junio C Hamano
2023-05-08 22:31 ` Taylor Blau [this message]
2023-05-10 23:29 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFl4UVhoR4Hlm2g3@nand.local \
--to=me@ttaylorr.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).