On Thu, May 11, 2023 at 05:39:06PM -0700, Junio C Hamano wrote: > * ps/fetch-output-format (2023-05-10) 9 commits > - fetch: introduce machine-parseable "porcelain" output format > - fetch: move option related variables into main function > - fetch: lift up parsing of "fetch.output" config variable > - fetch: introduce `display_format` enum > - fetch: refactor calculation of the display table width > - fetch: print left-hand side when fetching HEAD:foo > - fetch: add a test to exercise invalid output formats > - fetch: split out tests for output format > - fetch: fix `--no-recurse-submodules` with multi-remote fetches > > "git fetch" learned the "--porcelain" option that emits what it did > in a machine-parseable format. > > Will merge to 'next'? > source: From my point of view the series is ready to be merged now, and Glen has also given his Reviewed-by. We may add below diff to "fetch: introduce `display_format` enum". No further changes would be required for any of the other patches as we always explicitly initialize the value already and don't use the `UNKNOWN` value anywhere. diff --git a/builtin/fetch.c b/builtin/fetch.c index 462fc86b99..6583e31e3d 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -49,7 +49,6 @@ enum { }; enum display_format { - DISPLAY_FORMAT_UNKNOWN = 0, DISPLAY_FORMAT_FULL, DISPLAY_FORMAT_COMPACT, DISPLAY_FORMAT_PORCELAIN, I'm rather indifferent though and feel like re-sending all patches only to change this one line of code generates too much noise. But I'm happy to adjust in order to make your life easier. Thanks! Patrick