From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id A132F1F452 for ; Tue, 18 Apr 2023 19:48:34 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20221208.gappssmtp.com header.i=@ttaylorr-com.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=BRcT9x7W; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232625AbjDRTsT (ORCPT ); Tue, 18 Apr 2023 15:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232635AbjDRTsO (ORCPT ); Tue, 18 Apr 2023 15:48:14 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0A88AD2F for ; Tue, 18 Apr 2023 12:48:12 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-54fbb713301so230373177b3.11 for ; Tue, 18 Apr 2023 12:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20221208.gappssmtp.com; s=20221208; t=1681847292; x=1684439292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qv85kzwcUFCzZoXanh2pnRR8wBSS6PXyQKLP8e1zUE8=; b=BRcT9x7WVNhABqEycpqk/q/sw7CiuiHEsidkwmUe+xiZLKUDbQPQbzIN5XmarLmDk8 pXOHzyg5ZispeBZb7OWXtn0YWxB/FuNN3lZLuuL2cj13dx6KshliRLPz8F3s8/PAFWqA nGkoLO7VW3fmLk50CkZ/AS5vMF+6A8sqFh0xlwCPYwQV+Kf1Yv5eaGmSeOh7gYpPTnzS URSskPMqO1s3kz0n0roikxsS70/wM93i4e5KjtlNqvBAweU4UY7wyrIyVzS6e2V6PXDn xdGhdoldgZKu++3XeRNPqIXn+BeD0f8gwg7PENRVXoimcCPUQcKvmv76PaYXdfCJvXim i/hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681847292; x=1684439292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qv85kzwcUFCzZoXanh2pnRR8wBSS6PXyQKLP8e1zUE8=; b=ZLKepAdPsHbvHAuRrqs/+dlBoB13s9xtzaGw13Ah70lz1HrozeMKiWD66v9T756lIP prKx4Oq7b54xrHDHqp+5cS3i3YLn3ifqp4pAEPjjJNbgBI6+OYmB6HcoB7ayKvXz9ypF vw5BKMdVqM1TRsRmmr6wmZI2wA/ImQPmtsc71JlIciuN66pABaZ7j0Onlf3EGTwTuvTj fVQVbDnStYqgSD3SSjh8IOui06wuYjBK+iKsjsYuJuyRdyfu3UfZ7BugPV4He0+PkXd2 R0W9JOq00WsEQp3K9iDShxG2dmPh/1412mt5ojrTptKXvnSyn/BjU8q88MYbrEKn1zwx 52aA== X-Gm-Message-State: AAQBX9cUBq5fMTP5NT7xAT5n506I5SwN1feKoRkcZfTvAy58Hg4DWYVj VEJqjoxUxtx6PRTbkV+dAH07guKOuojuj3KRxCv2yA== X-Google-Smtp-Source: AKy350YzPQe7u2RyLGlVOMYjZxOMPTAigUCrjn1vtTVemmbYtGNwY0LNyd62I2uZtAbaOrXOePVfaQ== X-Received: by 2002:a81:7d43:0:b0:552:a605:e408 with SMTP id y64-20020a817d43000000b00552a605e408mr938641ywc.12.1681847291789; Tue, 18 Apr 2023 12:48:11 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id l69-20020a812548000000b00552a118d059sm2727552ywl.117.2023.04.18.12.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 12:48:11 -0700 (PDT) Date: Tue, 18 Apr 2023 15:48:10 -0400 From: Taylor Blau To: Jeff King Cc: git@vger.kernel.org, Derrick Stolee , Junio C Hamano Subject: Re: [PATCH 07/10] t/t6500-gc.sh: add additional test cases Message-ID: References: <6957e54f51759ff1b6d2469bc40c9b966635595d.1681764848.git.me@ttaylorr.com> <20230418104813.GF508219@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230418104813.GF508219@coredump.intra.peff.net> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Apr 18, 2023 at 06:48:13AM -0400, Jeff King wrote: > On Mon, Apr 17, 2023 at 04:54:33PM -0400, Taylor Blau wrote: > > > In the last commit, we refactored some of the tests in t6500 to make > > clearer when cruft packs will and won't be generated by `git gc`. > > > > Add the remaining cases not covered by the previous patch into this one, > > which enumerates all possible combinations of arguments that will > > produce (or not produce) a cruft pack. > > > > This prepares us for the following commit, which will change the default > > of `gc.cruftPacks` by ensuring that we understand which invocations do > > and do not change as a result. > > I think "the following commit" is really patch 9. Patch 8 adjusts t6501 > (and likewise says "like the previous commits"). It would probably make > more sense to put patch 8 before patches 6 and 7. I'm glad you said something, because shortly after I sent this series I was annoyed with myself for not organizing the preparatory patches in order of their test number. I reordered them like so: c02f80e1e2 t/t5304-prune.sh: prepare for `gc --cruft` by default 2e0fb1382b t/t6501-freshen-objects.sh: prepare for `gc --cruft` by default c916e6d356 t/t6500-gc.sh: refactor cruft pack tests f9f7b2137b t/t6500-gc.sh: add additional test cases 5a74520b35 t/t9300-fast-import.sh: prepare for `gc --cruft` by default Which feels much better to me. > Probably not worth a re-roll on its own, but if you're doing one anyway, > it should be easy to do. Agreed on both. I'm rerolling a few tiny things anyways, so I'll squash this in, too. Thanks, Taylor