From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] rebase: implement --rewind
Date: Wed, 5 Apr 2023 17:15:18 +0200 [thread overview]
Message-ID: <ZC2Qhi73YKSOJrM2@ugly> (raw)
In-Reply-To: <4fa6d2da-4885-09d9-dddb-6f19efda6398@gmx.de>
On Wed, Apr 05, 2023 at 02:07:29PM +0200, Johannes Schindelin wrote:
>This question brings me back to the initial question: What problem do
>we try to solve here? (This is a question that try as I might, I cannot
>see answered in the proposed commit message.)
>
and i, try as i might, don't understand what you're not understanding
...
>[...] In other words, I need a nested rebase.
>
that's just *your* private terminology. i don't apply the term "nested"
here, because for me that implies the possibility to "unnest", which my
patch doesn't implement. instead, it just continues past the point where
the rewind was initiated. it's the difference between a loop and
recursion.
but outside this difference in terminology, for all i can tell, my patch
implements *exactly* what you're asking for, and i don't understand why
that's not obvious to you, given how well you understand the problem
space yourself.
please describe what you want with _a few_ words and without introducing
any new terminology first, i.e., something you'd actually want to see in
the feature's summary documentation. that should illuminate what
keywords you find critical.
i just gave rewinding rebasing merges a shot, and it didn't work for the
simple reason that --rebase-merges is not saved in the state
(understandably, because that was unnecessary so far) and the
combination of --rewind --rebase-merges is being rejected. i'll need to
fix that.
then there is the problem that --rebase-merges only redoes merges rather
than replaying them. but it seems that the simple case with unmodified
parents actually does get replayed (or rather, skipped over, just
incredibly slowly), so rewinding to just the last merge would work fine.
other than that, i'm declaring the matter out of scope and deferring to
your "replaying evil merges" sub-thread.
next prev parent reply other threads:[~2023-04-05 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:22 [RFC PATCH] rebase: implement --rewind Oswald Buddenhagen
2023-03-28 14:53 ` Johannes Schindelin
2023-03-28 16:11 ` Oswald Buddenhagen
2023-04-05 12:07 ` Johannes Schindelin
2023-04-05 15:15 ` Oswald Buddenhagen [this message]
2023-04-06 10:45 ` Ævar Arnfjörð Bjarmason
2023-04-06 14:49 ` Oswald Buddenhagen
2023-04-07 0:21 ` Felipe Contreras
2023-04-07 7:00 ` Oswald Buddenhagen
2023-04-11 10:06 ` Phillip Wood
2023-04-06 10:01 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC2Qhi73YKSOJrM2@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).