From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id F04881F428 for ; Thu, 23 Mar 2023 21:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbjCWVxw (ORCPT ); Thu, 23 Mar 2023 17:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCWVxu (ORCPT ); Thu, 23 Mar 2023 17:53:50 -0400 Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90E16F773 for ; Thu, 23 Mar 2023 14:53:48 -0700 (PDT) Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 44BAB20386 for ; Thu, 23 Mar 2023 17:53:47 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1pfSsU-grA-00 for ; Thu, 23 Mar 2023 22:53:46 +0100 Date: Thu, 23 Mar 2023 22:53:46 +0100 From: Oswald Buddenhagen To: git@vger.kernel.org Subject: Re: [PATCH 2/3] sequencer: actually translate report in do_exec() Message-ID: Mail-Followup-To: git@vger.kernel.org References: <20230323162234.995485-1-oswald.buddenhagen@gmx.de> <20230323162234.995485-2-oswald.buddenhagen@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Mar 23, 2023 at 02:25:04PM -0700, Junio C Hamano wrote: >Oswald Buddenhagen writes: > >> yeah, but unless this is on someone's shortlist, i don't think it >> makes sense to hold up my fix. > >My point was that your "fix" is not really a "fix" that is worth the >code churn. Or did I mis-read your patches? > they all fix actual (minor) bugs: missing i18n, bad grammar (the missing periods between sentences actaully threw me off, which is how i got started on the series at all), and arguably bad capitalization (though obviously, for my own sake i couldn't care less about *that*).