From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] receive-pack: fix stale packfile locks when dying
Date: Thu, 9 Mar 2023 13:26:14 -0500 [thread overview]
Message-ID: <ZAokxsXGwgdNEmDc@nand.local> (raw)
In-Reply-To: <e16bd81bf9e251aa6959fbe10a3fbc215a4a1c12.1678367338.git.ps@pks.im>
On Thu, Mar 09, 2023 at 02:09:23PM +0100, Patrick Steinhardt wrote:
> Fix this race by installing an atexit(3P) handler that unlinks the keep
> file.
This reminded me of a discussion that I thought you and I had a few
months ago on the list about whether or not it was safe to call unlink()
in an async signal handler.
TL;DR, it is, and the link back to that discussion is here:
https://lore.kernel.org/git/YdjBkZsnYd+zYne1@nand.local/
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> builtin/receive-pack.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index cd5c7a28ef..0a6030d775 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -2186,6 +2186,12 @@ static const char *parse_pack_header(struct pack_header *hdr)
>
> static const char *pack_lockfile;
>
> +static void unlink_pack_lockfile(void)
> +{
> + if (pack_lockfile)
> + unlink(pack_lockfile);
> +}
> +
...and I think that this would all work, but I agree that using the
tempfile API here (as Peff suggests below) would probably be more
ergonomic.
Thanks,
Taylor
next prev parent reply other threads:[~2023-03-09 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 13:09 [PATCH] receive-pack: fix stale packfile locks when dying Patrick Steinhardt
2023-03-09 15:59 ` Jeff King
2023-03-10 6:24 ` Patrick Steinhardt
2023-03-10 8:37 ` Jeff King
2023-03-09 18:26 ` Taylor Blau [this message]
2023-03-09 18:48 ` Junio C Hamano
2023-03-09 18:49 ` Junio C Hamano
2023-03-10 6:52 ` [PATCH v2] " Patrick Steinhardt
2023-03-10 8:51 ` Jeff King
2023-03-10 11:49 ` Patrick Steinhardt
2023-03-10 13:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAokxsXGwgdNEmDc@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).