From: Jeff King <peff@peff.net>
To: Chris Torek <chris.torek@gmail.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] Add a CI for unsigned char system
Date: Thu, 9 Mar 2023 05:57:30 -0500 [thread overview]
Message-ID: <ZAm7mpf36IOCqgN4@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPx1GveS2=8-rh6PVFsOXLvJ4iZGzeo9uUdG=wcbophxiDam0g@mail.gmail.com>
On Thu, Mar 09, 2023 at 02:26:34AM -0800, Chris Torek wrote:
> On Thu, Mar 9, 2023 at 1:54 AM Jeff King <peff@peff.net> wrote:
> > I like the overall goal, but I'm not wild about having another CI
> > provider.
>
> So, why not do an x86 build with `-funsigned-char`? Seems to work with
> both gcc and clang.
Yeah, that would be even simpler. Though IMHO "unsigned char" is only
one interesting difference to be checking. Another would be having a
platform where unaligned access isn't tolerated. It would be nice to
have a big-endian platform, too, but I'm not sure if arm is a good fit
there (my impression is that it can be run in either mode?).
On the other hand, I think Ævar does periodically run on the gcc build
machines, which includes examples of each (including aarch64). And this
particular bug was found pretty quickly (within a week of it hitting
next, and only a day after hitting master). So while it might be nice to
have more immediate CI feedback, it does seem like the old "if the
platform matters, somebody will try it and report the problem" strategy
still works, too.
-Peff
prev parent reply other threads:[~2023-03-09 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 13:46 [PATCH 0/4] Add a CI for unsigned char system Đoàn Trần Công Danh
2023-03-03 13:46 ` [PATCH 1/4] ci/lib.sh: remove an useless break Đoàn Trần Công Danh
2023-03-03 13:46 ` [PATCH 2/4] ci/install-dependencies: libify p4 and git-lfs installation Đoàn Trần Công Danh
2023-03-03 13:46 ` [PATCH 3/4] ci/install-dependencies: install git-lfs for arm64 build Đoàn Trần Công Danh
2023-03-03 13:46 ` [PATCH 4/4] ci: add arm64 CI environment via CircleCI Đoàn Trần Công Danh
2023-03-03 13:54 ` Đoàn Trần Công Danh
2023-03-09 9:53 ` [PATCH 0/4] Add a CI for unsigned char system Jeff King
2023-03-09 10:26 ` Chris Torek
2023-03-09 10:57 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAm7mpf36IOCqgN4@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chris.torek@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).