From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5C0DD1F47D for ; Thu, 9 Mar 2023 03:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229582AbjCIDKF (ORCPT ); Wed, 8 Mar 2023 22:10:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjCIDKE (ORCPT ); Wed, 8 Mar 2023 22:10:04 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC33E769F9 for ; Wed, 8 Mar 2023 19:10:00 -0800 (PST) Received: (qmail 4515 invoked by uid 109); 9 Mar 2023 03:10:00 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 09 Mar 2023 03:10:00 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 27054 invoked by uid 111); 9 Mar 2023 03:09:59 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 08 Mar 2023 22:09:59 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 8 Mar 2023 22:09:59 -0500 From: Jeff King To: Eric Wong Cc: git@vger.kernel.org Subject: Re: [PATCH] fetch: pass --no-write-fetch-head to subprocesses Message-ID: References: <20230308100438.908471-1-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230308100438.908471-1-e@80x24.org> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 08, 2023 at 10:04:38AM +0000, Eric Wong wrote: > It seems a user would expect this option would work regardless > of whether it's fetching from a single remote or many. > > Signed-off-by: Eric Wong > --- > I haven't checked if there's other suitable options which could > go into add_options_to_argv(); hopefully someone else can check :> There's at least one that came up before: https://lore.kernel.org/git/DM5PR1701MB1724CCBB1AC5CF342BA9ADD5898E9@DM5PR1701MB1724.namprd17.prod.outlook.com/ but it never got turned into a real patch. This is obviously an error-prone mechanism. It would be nice if there was a way to avoid it, but after some discussion in this thread, we didn't come up with anything clever: https://lore.kernel.org/git/20200914121906.GD4705@pflmari/ -Peff