git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Gwyneth Morgan <gwymor@tilde.club>
Cc: git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Emily Shaffer" <emilyshaffer@google.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [RFC PATCH 2/2] docs: document a format for anonymous author and committer IDs
Date: Sun, 2 Oct 2022 00:27:21 +0000	[thread overview]
Message-ID: <Yzja6eSq15Q1a8Rs@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <YzdQwNCtwAYjhKWp@tilde.club>

[-- Attachment #1: Type: text/plain, Size: 2326 bytes --]

On 2022-09-30 at 20:26:41, Gwyneth Morgan wrote:
> In general, I like this proposal. It seems like a good way forward.
> 
> It should be made very clear to the user that a commit authored by a
> key-derived ID does not imply the commit is signed by that key or
> provide any security guarantees; anyone can put anything in that field,
> same as it is now. I could see someone seeing a commit authored by
> <47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU@_.sha256.ssh.id.git-scm.com>
> and thinking that implies the commit was signed by
> `47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU`.

Of course.  I'll update that when I turn this into a real series.

> On 2022-09-19 14:52:31+0000, brian m. carlson wrote:
> > +Anonymous IDs
> > +-------------
> > +
> > +Git will implement a new form of email address which is acceptable to existing
> > +implementations but is not valid according to RFC 1123.  This takes the form of
> > +an email address where the local-part contains the identifier and the domain
> > +portion starts with `_.` and then a domain specifier which specifies an
> > +authority and the meaning of the identifier.
> > +
> > +In such a case, Git will specify the username as a single U+2060 in UTF-8 (the
> > +byte sequence 0xE2 0x81 0xA0), which is a zero width non-breaking space.  This
> > +is compatible with existing implementations.
> 
> Could you add a note here explaining why that character was chosen for
> the name field? It seems like it would be easier to work with a single
> printable character like `?` or `X`, but maybe that doesn't matter here.

Sure, I'll include that there.  The author field cannot be empty for
compatibility reasons.  Since there's nothing to put there until it's
run through the mailmap, putting a single zero-width non-breaking space
produces the same rendering as nothing, and it doesn't require special
handling like "?" or "X". (Also, it should be noted that not all
languages use "?" as the question mark.)

Note that if this is mapped in the mailmap, you don't need to actually
put the personal name that exists in the commit.  The mailmap rewrites
based on the email address (or, in this case, the ID), so nobody ever
has to write the U+2060 in the mailmap.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

      reply	other threads:[~2022-10-02  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 14:52 [RFC PATCH 0/2] Opaque author and committer identifiers brian m. carlson
2022-09-19 14:52 ` [RFC PATCH 1/2] doc: specify a header for including arbitrary format-patch metadata brian m. carlson
2022-09-19 14:52 ` [RFC PATCH 2/2] docs: document a format for anonymous author and committer IDs brian m. carlson
2022-09-20 10:51   ` Ævar Arnfjörð Bjarmason
2022-09-22  0:08     ` brian m. carlson
2022-09-30 20:26   ` Gwyneth Morgan
2022-10-02  0:27     ` brian m. carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzja6eSq15Q1a8Rs@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gwymor@tilde.club \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).