From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8167F1F51E for ; Wed, 28 Sep 2022 15:40:28 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="0f/d0w3M"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232396AbiI1Pjw (ORCPT ); Wed, 28 Sep 2022 11:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbiI1Pjj (ORCPT ); Wed, 28 Sep 2022 11:39:39 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89BCF6361 for ; Wed, 28 Sep 2022 08:39:37 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id y141so10462636iof.5 for ; Wed, 28 Sep 2022 08:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=cY3N/diy/kKVSPhN8o3+mN2YRd8fVIwA46RXLRS/bMs=; b=0f/d0w3MOef+K3VCyzBOtmGtsTlsCIEKRhI2W76kvUnXf18Gan1frqDKrqKI9Y+o4n rwWvKnnf8HSKknxAiUO23f9wlSn6w6YuM+hQPchRS8gPLu4yCrS2XzYOCD0bL1boq4xF B1DKgtXVcPtPtW4I2Ov4BOQqAbRuTjnOMmnbcWUBIRflSEyrBRlyEDShoUpPKPBhg8Mt lUGJMNjEztdhgPhJQCtxCX6L26I+VcaDdBDZxf+P3QmcL7fzK16lrFfIMk2IndaJJfjx n5ARUyjf18U76r+07FUctKbriouT1ULKOY1/7nKyUP0rDj8AA0iAgaQtKlgQKm4duIBT XJRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=cY3N/diy/kKVSPhN8o3+mN2YRd8fVIwA46RXLRS/bMs=; b=XKPvABtlFaflWcgFJeFEZoOsFoRGYptTMUAUS2zMfk2qb8BRU9YwQPM3kqdG+bGdbf cq9VaBdLY/eniYLhNdTVs88pnXrOcIV6Dr/HHuNLAa7JvJZr4l7m+SdT/JJVByW9gklv F7eENKJjMsTbrFTiK9uSKhGWU9fNWi7RubONJcLE4t6fvrLRahbQNUaqcpb4wzz+QXGx gBhlm+VyFoCJv3fk1Xqnj9bzlkcEFGW/5hH4aRPzjmoolH1UptkHCKmk4ilCpKWJ9+Mp jvizV/H54rsulwDK1q+1qnW96pUjzbLV5CFoH6xqWtCsPKiT86ZZcY518qddAkZkxfki 30fQ== X-Gm-Message-State: ACrzQf2uzJxIV5IF6/pZXcP77SWRt4esvqL3UfskArDdgKTgidUzxLLa IXSR1uwo55EYetcG7QW01hjPvMcxPvaenw== X-Google-Smtp-Source: AMsMyM6XSozgj2yj/jQcH283jC0w+J7yoAxhdumuzNN/99xUTXLIXn9zYwceuTOXwTk+Ou4qx8Z26Q== X-Received: by 2002:a05:6638:2686:b0:35a:413a:b7a0 with SMTP id o6-20020a056638268600b0035a413ab7a0mr17282197jat.224.1664379576958; Wed, 28 Sep 2022 08:39:36 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id o17-20020a056638125100b0035678e2e175sm1859343jas.50.2022.09.28.08.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 08:39:36 -0700 (PDT) Date: Wed, 28 Sep 2022 11:39:35 -0400 From: Taylor Blau To: Skrab Sah Cc: Junio C Hamano , skrab-sah via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH] abspath.h is created. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Skrab, On Wed, Sep 28, 2022 at 01:02:22PM +0530, Skrab Sah wrote: > What is wrong here and what should i do to make it correct. I suspect that Junio's concern is that it appears the tool you're using to auto-generate these .h files moves the comments away from the declaration and into the header. I imagine that such a change would be improved if: - You kept the comment attached to the function declaration (and ensured that it was present in the header file). - And we dropped the "this file is auto-generated by ..." comment, since I don't imagine that folks will be interested in adding a new tool to the development toolchain. Thanks. Taylor