From: Jeff King <peff@peff.net>
To: Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>
Subject: Re: t9210-scalar.sh fails with SANITIZE=undefined
Date: Thu, 22 Sep 2022 15:12:19 -0400 [thread overview]
Message-ID: <Yyyzk3FVjmms7dkO@coredump.intra.peff.net> (raw)
In-Reply-To: <ff921c34-139a-9e2b-ca1f-d6f9f7213d1b@github.com>
On Thu, Sep 22, 2022 at 08:35:22AM -0400, Derrick Stolee wrote:
> > I didn't dig further. It's obviously new in v2.38.0-rc1, but I'm not
> > sure it's a show-stopper. It _might_ have been there all along, and is
> > just now surfacing. Or it might be in an existing experimental feature
> > that just wasn't exercised enough in the tests. Or if it really is new
> > in scalar, then it will only hurt people using scalar, which didn't
> > exist before. So I don't think it's a regression in the strictest sense,
> > but it might be nice to get a more accurate understanding of the problem
> > before the release.
>
> Interesting find!
>
> Here are the index-related settings that Scalar sets as of -rc1:
>
> * core.preloadIndex=true
> * index.threads=true
> * index.version=4
>
> My gut feeling is that index.version=4 might be the culprit. I thought
> we tested GIT_TEST_INDEX_VERSION=4 in some CI modes, but apparently we
> do not. Do you get the same error in other tests with that environment
> variable?
Yeah, that seems by far the most likely of those three. And indeed,
running with GIT_TEST_INDEX_VERSION=4 causes even t0000 to fail with the
same problem. A minimal reproduction in git.git is just:
make SANITIZE=undefined
git clone . tmp
cd tmp
rm .git/index
export GIT_INDEX_VERSION=4
../git reset --hard ;# ok, writes v4 index
../git reset --hard ;# fails reading unaligned v4 index
So it seems like a problem with the v4 format in general. Which...yikes.
-Peff
next prev parent reply other threads:[~2022-09-22 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:04 t9210-scalar.sh fails with SANITIZE=undefined Jeff King
2022-09-22 12:35 ` Derrick Stolee
2022-09-22 19:12 ` Jeff King [this message]
2022-09-22 22:09 ` Victoria Dye
2022-09-22 22:27 ` Jeff King
2022-09-22 22:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyyzk3FVjmms7dkO@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).