git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "John A. Leuenhagen" <john@zlima12.com>,
	Junio C Hamano <gitster@pobox.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] clone: allow "--bare" with "-o"
Date: Thu, 22 Sep 2022 02:18:02 -0400	[thread overview]
Message-ID: <Yyv+GjjauvvcX3M1@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTEF=jBoW07_eLQ_BAWxULfWtehVa-JbJKpS+8rPenSiQ@mail.gmail.com>

On Thu, Sep 22, 2022 at 01:58:36AM -0400, Eric Sunshine wrote:

> > diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh
> > @@ -42,11 +42,12 @@ test_expect_success 'rejects invalid -o/--origin' '
> > +test_expect_success 'clone --bare -o' '
> > +       git clone -o foo --bare parent clone-bare-o &&
> > +       (cd parent && pwd) >expect &&
> > +       git -C clone-bare-o config remote.foo.url >actual &&
> > +       test_cmp expect actual
> >  '
> 
> Is this safe on Microsoft Windows? My understanding from t/README:
> 
>     When a test checks for an absolute path that a git command
>     generated, construct the expected value using $(pwd) rather than
>     $PWD, $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference
>     on Windows, where the shell (MSYS bash) mangles absolute path
>     names. For details, see the commit message of 4114156ae9.
> 
> was that you should use $(pwd) rather than raw `pwd` when comparing
> against a path generated by Git. Is there a gap in my understanding
> here?

I think you might be mis-reading the advice here. It is saying to use
the "pwd" program, rather than relying on the shell's $PWD variable. So
$(pwd) and `pwd` are the same thing (and are what I'm using). The $() I
think is just indicating that you'd do:

  foo=$(pwd)

And yes, I think this is a case where using the right one is important
(which is why I used the pwd program, and not $pwd in the test).

Or am I missing something else?

-Peff

  reply	other threads:[~2022-09-22  6:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 19:23 fatal: options '--bare' and '--origin foo' cannot be used together John A. Leuenhagen
2022-09-22  4:55 ` Jeff King
2022-09-22  5:31   ` Jeff King
2022-09-22  5:32     ` [PATCH 1/2] clone: allow "--bare" with "-o" Jeff King
2022-09-22  5:58       ` Eric Sunshine
2022-09-22  6:18         ` Jeff King [this message]
2022-09-22  6:26           ` Eric Sunshine
2022-09-22  6:35             ` Jeff King
2022-09-22  6:40               ` Eric Sunshine
2022-09-22  6:26           ` Jeff King
2022-09-22  5:33     ` [PATCH 2/2] remote: handle rename of remote without fetch refspec Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yyv+GjjauvvcX3M1@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@zlima12.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).