From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id D5E131F506 for ; Tue, 20 Sep 2022 19:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbiITTzu (ORCPT ); Tue, 20 Sep 2022 15:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbiITTzs (ORCPT ); Tue, 20 Sep 2022 15:55:48 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 657B6422F0 for ; Tue, 20 Sep 2022 12:55:47 -0700 (PDT) Received: (qmail 30907 invoked by uid 109); 20 Sep 2022 19:55:46 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 20 Sep 2022 19:55:46 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14381 invoked by uid 111); 20 Sep 2022 19:55:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 20 Sep 2022 15:55:47 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 20 Sep 2022 15:55:46 -0400 From: Jeff King To: Alex Henrie Cc: git@vger.kernel.org, gitster@pobox.com Subject: Re: [PATCH] gc: don't translate literal commands Message-ID: References: <20220920050725.326383-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 20, 2022 at 01:43:56PM -0600, Alex Henrie wrote: > > So maybe something like: > > > > There are no human-readable parts of these strings; the command you > > type is still "git maintenance" even in other languages. > > By "placeholders" I mean "things in angle brackets", like some of the > other usage strings in this file have. Maybe "argument placeholders" > would be more clear. I like that term a little better than the term > "human-readable parts" because these strings are part of the user > interface, so humans have to read them. But I really don't care > whether there's any explanation in the commit message at all. Junio > could just drop the sentence altogether when he commits the patch. Yeah. It was mostly that the term actively misled me. ;) Just the subject (with "literal command") would probably be enough in this case. -Peff