From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8938D1F506 for ; Tue, 20 Sep 2022 19:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbiITTHQ (ORCPT ); Tue, 20 Sep 2022 15:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbiITTHO (ORCPT ); Tue, 20 Sep 2022 15:07:14 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63AAF75493 for ; Tue, 20 Sep 2022 12:07:12 -0700 (PDT) Received: (qmail 30699 invoked by uid 109); 20 Sep 2022 19:07:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 20 Sep 2022 19:07:11 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 13715 invoked by uid 111); 20 Sep 2022 19:07:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 20 Sep 2022 15:07:11 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 20 Sep 2022 15:07:10 -0400 From: Jeff King To: Alex Henrie Cc: git@vger.kernel.org, gitster@pobox.com Subject: Re: [PATCH] gc: don't translate literal commands Message-ID: References: <20220920050725.326383-1-alexhenrie24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220920050725.326383-1-alexhenrie24@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote: > These commands have no placeholders to be translated. I think this is the right thing to do, but your commit message made me pause for a second. When you say "placeholders", I think you mean %s, etc. And yes there aren't any here, but that is not the reason not to translate. The reason not to translate is that the strings are commands which are given to a machine. So maybe something like: There are no human-readable parts of these strings; the command you type is still "git maintenance" even in other languages. Regardless, the patch looks good to me. Thanks for catching it. -Peff