From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-10.8 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 47DDE1F506 for ; Mon, 19 Sep 2022 20:15:17 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="R85xTw+D"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiISUPN (ORCPT ); Mon, 19 Sep 2022 16:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbiISUPL (ORCPT ); Mon, 19 Sep 2022 16:15:11 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798A124951 for ; Mon, 19 Sep 2022 13:15:09 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id s90-20020a17090a2f6300b00203a685a1aaso343274pjd.1 for ; Mon, 19 Sep 2022 13:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date; bh=8fbGp5TEvlae/oZ7xY7bHgsXZ8/07owxwv0Tp81bYdY=; b=R85xTw+DdpnSzQ392up9eGepUDeLvoX1l92P5HCBL04efxl3mGovEh0vZ9KnoV1X7c aU1QCCoJDQids7mhVTXrVgRHJkRBDw/92VuJoyGlOWUwCj8hgivPUpPpnw2TJbDlQFCM 9C8nqPuWg2o6NTlwZx07H0HyiBFn5AJ/cTqSHZ8TsQzL4MSzg1yz7cTd/9xzs2qpwSOf NUZZYSHsEoex76sGwCzVEUwqpVxidGM4Q0xFsuES2+1mXV6RpQCwyEI9WZQ0DDCexB1O V57pXpmqGFy4OvQkbPg9R5OY+hA/ZJgYzQ4nfPPbmeXC4TQ9OnWqgw4IqfiJ4EMgfRbl I2qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=8fbGp5TEvlae/oZ7xY7bHgsXZ8/07owxwv0Tp81bYdY=; b=ZBY/s+0DCEzyHsYSDgHSAb6Vr/+c83a7q0w9gkZH35wJ7fqhLokm/usxxiHWsXl9gy HBtM+HxbLlan9a5kvQZHxvd1ljrimi+Kwp2EntgpDa0L2sFnlpjwpMf7qNpvaUguJzv5 W8UHAS0UmxZzpLjLCpuKwHG/Pn7Xqm5OJ11OS/vk9Ad01J7Vzl6OrSvSwIAxt8ag2m+3 XY+bwGWZGgqa2Wer9Qk3Oj9EA+cpr1U54QsrblmM1ZKcd4zhR3mq0zhykxBi4WQ04IHP eSf2gcsCCbS2gbeWQE1uizNWF03do7yvHf6kXk+e6yO6qiAq+OWCAoMbxZ8WnXuWHAA9 x6wg== X-Gm-Message-State: ACrzQf1ds0oY6zUaalWUZ5np0B9i6q0eyAvp00yAnMefVpFqhqjwUyEW r4+02EXfWnOnwQyV9UkiLhVTQA== X-Google-Smtp-Source: AMsMyM5qYn2UdoS7isb06+YuGjnWurnQfebLjUMNGGBGzAN1g0sCdO1cNmrRLSaAQ48zzjVz7+RFuA== X-Received: by 2002:a17:902:f546:b0:177:ed6b:4696 with SMTP id h6-20020a170902f54600b00177ed6b4696mr1371695plf.171.1663618508904; Mon, 19 Sep 2022 13:15:08 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2256:74b3:e7d0:31fb]) by smtp.gmail.com with ESMTPSA id o6-20020a170902d4c600b0016b81679c1fsm21308919plg.216.2022.09.19.13.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 13:15:08 -0700 (PDT) Date: Mon, 19 Sep 2022 13:15:02 -0700 From: Josh Steadmon To: Victoria Dye via GitGitGadget Cc: git@vger.kernel.org, derrickstolee@github.com, Johannes.Schindelin@gmx.de, chooglen@google.com, gitster@pobox.com, Victoria Dye Subject: Re: [PATCH v2] Documentation: add ReviewingGuidelines Message-ID: Mail-Followup-To: Josh Steadmon , Victoria Dye via GitGitGadget , git@vger.kernel.org, derrickstolee@github.com, Johannes.Schindelin@gmx.de, chooglen@google.com, gitster@pobox.com, Victoria Dye References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2022.09.19 19:12, Victoria Dye via GitGitGadget wrote: > From: Victoria Dye > > Add a reviewing guidelines document including advice and common terminology > used in Git mailing list reviews. The document is included in the > 'TECH_DOCS' list in order to include it in Git's published documentation. > > Helped-by: Johannes Schindelin > Helped-by: Derrick Stolee > Helped-by: Junio C Hamano > Helped-by: Josh Steadmon > Signed-off-by: Victoria Dye > --- Looks great, thanks! Reviewed-by: Josh Steadmon