From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v2 2/3] midx.c: use `pack-objects --stdin-packs` when repacking
Date: Fri, 23 Sep 2022 14:28:49 -0400 [thread overview]
Message-ID: <Yy364WAutGIdXCub@nand.local> (raw)
In-Reply-To: <5172dbb7-61d1-7249-f9bb-d760e6f4450a@github.com>
On Fri, Sep 23, 2022 at 02:23:30PM -0400, Derrick Stolee wrote:
> Do you know if there is any reason to do this explicitly? Does this
> change the set of objects in any way (perhaps by not including
> duplicates that are tracked in those other packs)?
Yes. The "^" lines become excluded packs from the perspective of the
follow-on reachability traversal to discover the namehashes. So as soon
as we hit an object contained in one of the packs marked as excluded,
we'll halt the traversal along that direction, since we know that we're
not going to pick up any objects in those packs.
So you could omit them, and you'd get the same resulting pack, but it
would take longer to generate since we wouldn't be stopping the
follow-on traversal as early as possible.
Thanks,
Taylor
next prev parent reply other threads:[~2022-09-23 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YyokIf%2FSd7SYztKQ@nand.local>
2022-09-20 20:40 ` [PATCH v2 0/3] midx: use `--stdin-packs` to implement `repack` Taylor Blau
2022-09-20 20:40 ` [PATCH v2 1/3] midx.c: compute pack_info array outside of fill_included_packs_batch() Taylor Blau
2022-09-20 20:40 ` [PATCH v2 2/3] midx.c: use `pack-objects --stdin-packs` when repacking Taylor Blau
2022-09-23 18:23 ` Derrick Stolee
2022-09-23 18:28 ` Taylor Blau [this message]
2022-09-23 19:05 ` Derrick Stolee
2022-09-20 20:40 ` [PATCH v2 3/3] midx.c: unify `include_pack` array into `pack_info` struct Taylor Blau
2022-09-20 21:54 ` [PATCH v2 0/3] midx: use `--stdin-packs` to implement `repack` Jeff King
2022-09-21 19:09 ` Junio C Hamano
2022-09-23 18:29 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy364WAutGIdXCub@nand.local \
--to=me@ttaylorr.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).