From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Adam Dinwoodie" <adam@dinwoodie.org>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Johannes Sixt" <j6t@kdbg.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>
Subject: Re: [PATCH] t1800: correct test to handle Cygwin
Date: Fri, 2 Sep 2022 08:55:40 +0700 [thread overview]
Message-ID: <YxFinAJ2NeKiHaS8@danh.dev> (raw)
In-Reply-To: <xmqqedwv9c9f.fsf@gitster.g>
On 2022-09-01 11:32:12-0700, Junio C Hamano <gitster@pobox.com> wrote:
> In any case, thanks for a fix. Will queue.
>
> > t/t1800-hook.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
> > index 64096adac7..fae8b2faf9 100755
> > --- a/t/t1800-hook.sh
> > +++ b/t/t1800-hook.sh
> > @@ -159,7 +159,7 @@ test_expect_success 'git hook run a hook with a bad shebang' '
> > # TODO: We should emit the same (or at least a more similar)
> > # error on Windows and !Windows. See the OS-specific code in
Please also change the comment here too.
I'm not sure what should be put in the comment here, though.
Maybe on MINGW and other platforms?
> > # start_command()
> > - if test_have_prereq !WINDOWS
> > + if test_have_prereq !MINGW
> > then
> > cat >expect <<-\EOF
> > fatal: cannot run bad-hooks/test-hook: ...
--
Danh
next prev parent reply other threads:[~2022-09-02 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 17:39 [PATCH] t1800: correct test to handle Cygwin Adam Dinwoodie
2022-09-01 18:32 ` Junio C Hamano
2022-09-02 1:55 ` Đoàn Trần Công Danh [this message]
2022-09-02 12:22 ` Johannes Schindelin
2022-09-07 20:49 ` Junio C Hamano
2022-09-07 20:57 ` rsbecker
2022-09-13 21:08 ` Adam Dinwoodie
2022-09-13 21:33 ` Junio C Hamano
2022-09-15 7:57 ` [PATCH v2] " Adam Dinwoodie
2022-09-15 8:51 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxFinAJ2NeKiHaS8@danh.dev \
--to=congdanhqx@gmail.com \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).