From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 35EFF1F54E for ; Tue, 13 Sep 2022 00:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbiIMAEb (ORCPT ); Mon, 12 Sep 2022 20:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbiIMAE3 (ORCPT ); Mon, 12 Sep 2022 20:04:29 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54FB31B4 for ; Mon, 12 Sep 2022 17:04:26 -0700 (PDT) Received: (qmail 29348 invoked by uid 109); 13 Sep 2022 00:04:25 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 13 Sep 2022 00:04:25 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 19529 invoked by uid 111); 13 Sep 2022 00:04:26 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 12 Sep 2022 20:04:26 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 12 Sep 2022 20:04:24 -0400 From: Jeff King To: Eric Sunshine Cc: Eric Sunshine via GitGitGadget , Git List , Elijah Newren , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Fabian Stelzer , Johannes Schindelin Subject: Re: [PATCH 00/18] make test "linting" more comprehensive Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 12, 2022 at 07:17:12PM -0400, Eric Sunshine wrote: > > I think we can live with it as-is for now and see how people react. If > > lots of people are getting confused by the output, then that motivates > > finding a solution. If not, then it's probably not worth the time. > > Well, you nerd-sniped me anyhow. The result is at [1]. Following the It seems we've discovered my true talent. :) > example of t/test-lib.sh, it uses `tput` if available to avoid > hardcoding color codes, and `tput` is invoked lazily, only if it > detects problems in the tests, so a normal (non-problematic) run > doesn't incur the overhead of shelling out to `tput`. Ah, of course. I didn't think about the fact that the regular tests already had to deal with this problem. Following that lead makes perfect sense. -Peff