From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id D32D01F54E for ; Sun, 14 Aug 2022 06:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230415AbiHNGxA (ORCPT ); Sun, 14 Aug 2022 02:53:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230062AbiHNGw7 (ORCPT ); Sun, 14 Aug 2022 02:52:59 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D62043330 for ; Sat, 13 Aug 2022 23:52:58 -0700 (PDT) Received: (qmail 18589 invoked by uid 109); 14 Aug 2022 06:52:57 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sun, 14 Aug 2022 06:52:57 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31632 invoked by uid 111); 14 Aug 2022 06:52:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 14 Aug 2022 02:52:58 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 14 Aug 2022 02:52:57 -0400 From: Jeff King To: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh Cc: git@vger.kernel.org Subject: Re: t7527 intermittent failure on macOS APFS and possible fix Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 12, 2022 at 08:52:24PM +0700, Đoàn Trần Công Danh wrote: > Running t7527 on macOS with encrypted APFS filesystem. > I observes intermittent failure, however, when I manually check the > test cases, they're all passed. > > I suspected fileystem caching issue. > I added those sync-s into test steps and the test pass. > I'm not sure if this is the intending "fix" for the tests > since we're testing the fsmonitor with t7527. I don't know anything about your problem area, but some tools in our test suite that might help you get better results with an intermittent problem (if you didn't already know about them): - add: GIT_TEST_OPTS = -x --verbose-log into config.mak. Then when a "make test" run fails, you can see the log in t/test-results/t7527-*.out. - try running: ./t7527-* --stress which will run a bunch of instances simultaneously, with the idea that the load will introduce timing issues that will trigger the bug. The failed instance will produce a detailed log on stdout. That might help you get more output from the failing cases. -Peff