From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Todd Zullinger <tmz@pobox.com>,
Renato Botelho <garga@freebsd.org>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git maintenance broken on FreeBSD
Date: Sat, 13 Aug 2022 22:37:54 +0700 [thread overview]
Message-ID: <YvfFUuuydtYeuvRx@danh.dev> (raw)
In-Reply-To: <xmqqczd4ag8f.fsf@gitster.g>
On 2022-08-12 22:02:08-0700, Junio C Hamano <gitster@pobox.com> wrote:
> Todd Zullinger <tmz@pobox.com> writes:
>
> > If a change like this is made, aren't we trading one group
> > of broken users for another? It would fix users of newer
> > systems at the expense of those on older systems, I would
> > suspect.
>
> So, it is fairly clear that "crontab" wants a real file. Somebody's
> POSIX compliant "crontab" can be fed "-", attempt to read from a
> file with such a name, and legitimately fail. And on such a system,
> the proposed patch causes a regression.
Then, we are getting back to point #0, we don't have universally way
to specify stdin as input file for crontab(1) and "crontab -e" is
optional.
Perhaps, FreeBSD needs to carry this patch downstream; or
we will invent new preprocessor, let's say CRONTAB_DASH_IS_STDIN
which is defined in FreeBSD, and another config, let's say
crontab.dashIsStdin (in order to allow users swap their default
cron) which is default to 1 if CRONTAB_DASH_IS_STDIN is defined,
and 0 otherwise. So, everyone will be happy. Thought?
--
Danh
next prev parent reply other threads:[~2022-08-13 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 13:51 git maintenance broken on FreeBSD Renato Botelho
2022-08-12 14:44 ` Đoàn Trần Công Danh
2022-08-13 3:42 ` Todd Zullinger
2022-08-13 5:02 ` Junio C Hamano
2022-08-13 15:37 ` Đoàn Trần Công Danh [this message]
2022-08-13 17:26 ` Junio C Hamano
2022-08-13 17:35 ` brian m. carlson
2022-08-15 13:22 ` Derrick Stolee
2022-08-15 16:09 ` Junio C Hamano
2022-08-23 1:01 ` [PATCH] gc: use temporary file for editing crontab brian m. carlson
2022-08-23 9:12 ` Johannes Schindelin
2022-08-23 17:06 ` Derrick Stolee
2022-08-23 21:15 ` brian m. carlson
2022-08-24 16:06 ` Junio C Hamano
2022-08-28 21:41 ` [PATCH v2] " brian m. carlson
2022-08-29 6:46 ` Junio C Hamano
2022-08-29 10:52 ` Renato Botelho
2022-08-30 13:27 ` Derrick Stolee
2022-08-30 20:40 ` [PATCH] test-crontab: minor memory and error handling fixes Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvfFUuuydtYeuvRx@danh.dev \
--to=congdanhqx@gmail.com \
--cc=garga@freebsd.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).