From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id EBA141F54E for ; Tue, 9 Aug 2022 12:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239116AbiHIM4A (ORCPT ); Tue, 9 Aug 2022 08:56:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243332AbiHIMz4 (ORCPT ); Tue, 9 Aug 2022 08:55:56 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41BBCC18 for ; Tue, 9 Aug 2022 05:55:54 -0700 (PDT) Received: (qmail 30680 invoked by uid 109); 9 Aug 2022 12:55:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 09 Aug 2022 12:55:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 2027 invoked by uid 111); 9 Aug 2022 12:55:53 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 09 Aug 2022 08:55:53 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 9 Aug 2022 08:55:53 -0400 From: Jeff King To: Emily Noneman Cc: Junio C Hamano , Derrick Stolee , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, Paul Horn Subject: Re: [PATCH] revision.c: set-up "index_state.repo", don't segfault in pack-objects Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Aug 08, 2022 at 02:15:21PM -0400, Emily Noneman wrote: > The latest changes seem to have resolved the issue for me. My repo was > a bit different than Pauls, it's a big corporate repo with a partial > checkout and a worktree. What's confusing is that I do see an "index" > file in worktrees/NetLedger_GitRepo , but git 2.37.1 exhibits the > crash. 2.37.1.377.g679aad9e82 works just fine. Thanks for testing. It is odd that you see an "index" file, since the code change is definitely focused around getting ENOENT from open() on the index. Is it possible that you have another worktree (even the initial one) without an index in it? -Peff