From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8EE1A1F54E for ; Wed, 3 Aug 2022 17:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236999AbiHCRdb (ORCPT ); Wed, 3 Aug 2022 13:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236024AbiHCRd1 (ORCPT ); Wed, 3 Aug 2022 13:33:27 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69282564CB for ; Wed, 3 Aug 2022 10:33:26 -0700 (PDT) Received: (qmail 8359 invoked by uid 109); 3 Aug 2022 17:33:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 03 Aug 2022 17:33:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 13248 invoked by uid 111); 3 Aug 2022 17:33:25 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 03 Aug 2022 13:33:25 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 3 Aug 2022 13:33:25 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Eric Sunshine Subject: Re: [PATCH v3 0/6] revisions API: fix more memory leaks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Aug 02, 2022 at 05:33:10PM +0200, Ævar Arnfjörð Bjarmason wrote: > Changes since v2: > > * I think the rewrite here of fixing the leak should address Jeff > King's concerns. I was somewhat mentally stuck on trying to change > the code to make the leak fix easier, and then having the leak fix. > > But I think as the new 3/6 shows fixing the leak first is much > easier, and more straightforward to explain. Yeah, I think fixing the leak first is fine. I did prefer the end result of the earlier round, but I can live with it either way. > * A new 4/6 then follows-up and rewrites the variable clobbering that > was needed for the pre-image of 3/6. > > * Don't reference the "XXX" comment in 6/6. I'd hoped you'd take my replacement 5/6, but again, I can live with it either way. -Peff