From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 4E2591F54E for ; Sun, 31 Jul 2022 00:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233302AbiGaAfP (ORCPT ); Sat, 30 Jul 2022 20:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiGaAfO (ORCPT ); Sat, 30 Jul 2022 20:35:14 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1EFC5FC8 for ; Sat, 30 Jul 2022 17:35:12 -0700 (PDT) Received: (qmail 28125 invoked by uid 109); 31 Jul 2022 00:35:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sun, 31 Jul 2022 00:35:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7990 invoked by uid 111); 31 Jul 2022 00:35:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 30 Jul 2022 20:35:11 -0400 Authentication-Results: peff.net; auth=none Date: Sat, 30 Jul 2022 20:35:10 -0400 From: Jeff King To: Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, gitster@pobox.com, johannes.schindelin@gmx.de, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Phillip Wood , Derrick Stolee Subject: Re: [PATCH v3 3/5] git.txt: remove redundant language Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jul 19, 2022 at 06:32:15PM +0000, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The documentation for GIT_ALLOW_PROTOCOL has a sentence that adds no > value, since it repeats the meaning from the previous sentence (twice!). I think the point the original was trying to make was emphasizing that when the variable is set at all, then we operate in this new mode. Maybe that's sufficiently conveyed in the first sentence, but perhaps another way of expanding would be: If the variable is unset, it has no effect, and the normal configuration is respected. But perhaps that is obvious enough from the previous sentence. Since I was involved in drafting the original, I'm not sure I'm a good judge of what is obvious and what is not. :) -Peff