git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2022, #08; Fri, 29)
Date: Sat, 30 Jul 2022 20:29:22 -0400	[thread overview]
Message-ID: <YuXM4pmsuDzIqbQT@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq7d3v33to.fsf@gitster.g>

On Fri, Jul 29, 2022 at 04:18:59PM -0700, Junio C Hamano wrote:

> * jk/struct-zero-init-with-older-gcc (2022-07-29) 1 commit
>  - config.mak.dev: squelch -Wno-missing-braces for older gcc
> 
>  Older gcc with -Wall complains about the universal zero initializer
>  "struct s = { 0 };" idiom, which makes developers' lives
>  inconvenient (as -Werror is enabled by DEVELOPER=YesPlease).  The
>  build procedure has been tweaked to help them with thes compilers.
> 
>  Will merge to 'next'.
>  source: <YuQ60ZUPBHAVETD7@coredump.intra.peff.net>

If you get a chance before merging, can you please squash in this
typo-fix?

diff --git a/config.mak.dev b/config.mak.dev
index b9878a4994..4fa19d361b 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -60,7 +60,7 @@ endif
 # uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
 # not worth fixing since newer compilers correctly stop complaining
 #
-# Likwise, gcc older than 4.9 complains about initializing a
+# Likewise, gcc older than 4.9 complains about initializing a
 # struct-within-a-struct using just "{ 0 }"
 ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
 ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)

Thanks.

-Peff

  reply	other threads:[~2022-07-31  0:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 23:18 What's cooking in git.git (Jul 2022, #08; Fri, 29) Junio C Hamano
2022-07-31  0:29 ` Jeff King [this message]
2022-07-31 18:50   ` Junio C Hamano
2022-08-01 12:01 ` ab/leak-check (was: What's cooking in git.git (Jul 2022, #08; Fri, 29)) Ævar Arnfjörð Bjarmason
2022-08-01 16:56   ` ab/leak-check Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuXM4pmsuDzIqbQT@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).